diff --git a/docs/development/README.md b/docs/development/README.md
index b565506..37a169c 100644
--- a/docs/development/README.md
+++ b/docs/development/README.md
@@ -33,7 +33,7 @@ AI 工具必须严格遵守以下全部约束。
**前端**：优先复用已有组件/hooks/依赖库；确需新增依赖时先说明原因。
-**Zod**：已引入但未使用（预留），配置校验用 TypeBox + Ajv，不得混用 Zod。
+**Zod**：AI 工具层（`src/server/ai/tools/`）使用 Zod 定义 `tool()` 的 `inputSchema`，以满足 AI SDK 对 `ZodSchema` 的类型推断要求，属于框架级约束而非项目选型冲突。配置校验层使用 TypeBox + Ajv，两层级各司其职，不混用。
### 目录边界
diff --git a/eslint-rules/enforce-catch-type.js b/eslint-rules/enforce-catch-type.js
index ec01471..a007b52 100644
--- a/eslint-rules/enforce-catch-type.js
+++ b/eslint-rules/enforce-catch-type.js
@@ -25,6 +25,9 @@ export const enforceCatchType = {
if (type?.type === "TSTypeReference") {
return type.typeName?.name === "unknown";
}
+ if (type?.type === "TSUnknownKeyword") {
+ return true;
+ }
return false;
}
@@ -45,12 +48,7 @@ export const enforceCatchType = {
}
}
- if (
- body &&
- body.type === "BlockStatement" &&
- body.body.length === 0 &&
- !hasCommentsInBody(body)
- ) {
+ if (body && body.type === "BlockStatement" && body.body.length === 0 && !hasCommentsInBody(body)) {
context.report({ node: body, messageId: "emptyCatchNoComment" });
}
}
@@ -59,4 +57,4 @@ export const enforceCatchType = {
CatchClause: check,
};
},
-};
\ No newline at end of file
+};
diff --git a/eslint-rules/no-empty-function.js b/eslint-rules/no-empty-function.js
index 2d9072b..b6e597c 100644
--- a/eslint-rules/no-empty-function.js
+++ b/eslint-rules/no-empty-function.js
@@ -2,14 +2,10 @@ export const noEmptyFunction = {
meta: {
type: "problem",
docs: {
- description:
- "禁止空函数体，并提供项目约定的修复指引：生产代码使用 () => undefined，测试代码使用 () => {} + eslint-disable",
+ description: "禁止空函数体。修复方式：在函数体内添加注释说明为何为空实现（如接口契约、测试桩、noop）。",
},
messages: {
- unexpectedProduction:
- "生产代码中空函数应使用 () => undefined 明确表意（如 noop/voidLog）。如果确需空实现且为接口契约，请添加注释说明原因。",
- unexpectedTest:
- "测试代码中空函数使用 () => {} 并在文件顶部添加 /* eslint-disable @typescript-eslint/no-empty-function */。",
+ unexpected: "空函数体禁止使用。请在 {} 内添加注释说明原因，例如：/* 实现 Logger 接口契约，有意静默丢弃 */。",
},
schema: [],
},
@@ -17,17 +13,11 @@ export const noEmptyFunction = {
create(context) {
const sourceCode = context.sourceCode ?? context.getSourceCode();
- const allowedFunctionTypes = new Set([
- "ArrowFunctionExpression",
- "FunctionDeclaration",
- "FunctionExpression",
- ]);
+ const allowedFunctionTypes = new Set(["ArrowFunctionExpression", "FunctionDeclaration", "FunctionExpression"]);
function isEmptyBody(body) {
return (
- body.type === "BlockStatement" &&
- body.body.length === 0 &&
- sourceCode.getCommentsInside(body).length === 0
+ body.type === "BlockStatement" && body.body.length === 0 && sourceCode.getCommentsInside(body).length === 0
);
}
@@ -54,12 +44,9 @@ export const noEmptyFunction = {
if (isPrivateOrProtectedConstructor(node)) return;
if (isOverrideMethod(node)) return;
- const isTest = /[\\/]tests?[\\/]/.test(context.filename ?? "") || context.filename?.includes("test");
-
context.report({
node,
- messageId: isTest ? "unexpectedTest" : "unexpectedProduction",
- data: { name: node.id?.name ?? node.key?.name ?? "function" },
+ messageId: "unexpected",
});
}
diff --git a/src/server/bootstrap.ts b/src/server/bootstrap.ts
index 465b5fb..1b7df44 100644
--- a/src/server/bootstrap.ts
+++ b/src/server/bootstrap.ts
@@ -47,7 +47,7 @@ export async function bootstrap(options: BootstrapOptions, dependencies: Bootstr
try {
logger = await buildLogger(config.logging, options.mode, options.version);
- } catch (logInitError) {
+ } catch (logInitError: unknown) {
createFallback().fatal(
`日志初始化失败: ${logInitError instanceof Error ? logInitError.message : String(logInitError)}`,
);
@@ -83,7 +83,7 @@ export async function bootstrap(options: BootstrapOptions, dependencies: Bootstr
staticAssets: options.staticAssets,
version: options.version,
});
- } catch (error) {
+ } catch (error: unknown) {
if (logger) {
logger.fatal({ error: error instanceof Error ? error.message : String(error) }, "启动失败");
logger.flush();
diff --git a/src/server/config.ts b/src/server/config.ts
index 45c5050..8fbcda4 100644
--- a/src/server/config.ts
+++ b/src/server/config.ts
@@ -192,7 +192,7 @@ function validateLoggingConfig(logging: LoggingConfig | undefined, issues: Confi
if (bytes <= 0) {
issues.push(issue("invalid-value", "server.logging.file.rotation.size", "滚动大小必须为正整数字节数"));
}
- } catch (error) {
+ } catch (error: unknown) {
issues.push(
issue(
"invalid-value",
diff --git a/src/server/db/index.ts b/src/server/db/index.ts
index 403d0cd..c14b0a1 100644
--- a/src/server/db/index.ts
+++ b/src/server/db/index.ts
@@ -11,4 +11,13 @@ export {
} from "./conversations";
export { loadMigrationsFromDir, type MigrationRecord } from "./load-migrations";
export { runMigrations } from "./migrate";
+export {
+ createModel,
+ deleteModel,
+ getModel,
+ getModelsByProviderId,
+ getModelWithProvider,
+ listModels,
+ updateModel,
+} from "./models";
export { conversations, messages, projects, schemaMigrations } from "./schema";
diff --git a/src/server/db/models.ts b/src/server/db/models.ts
index 12a3c5e..5ba8a13 100644
--- a/src/server/db/models.ts
+++ b/src/server/db/models.ts
@@ -90,6 +90,38 @@ export function getModelsByProviderId(raw: Database, providerId: string): number
return Number(result?.count ?? 0);
}
+export function getModelWithProvider(
+ raw: Database,
+ modelId: string,
+):
+ | { error: string; status: number }
+ | {
+ model: { modelId: string; name: string; providerId: string };
+ provider: { apiKey: string; baseUrl: string; id: string; type: string };
+ } {
+ const db = wrap(raw);
+ const row = db.select().from(models).where(eq(models.id, modelId)).get();
+
+ if (!row) return { error: "模型不存在", status: 404 };
+
+ const providerRow = db.select().from(providers).where(eq(providers.id, row.providerId)).get();
+ if (!providerRow) return { error: "供应商不存在", status: 404 };
+
+ return {
+ model: {
+ modelId: row.modelId,
+ name: row.name,
+ providerId: row.providerId,
+ },
+ provider: {
+ apiKey: providerRow.apiKey,
+ baseUrl: providerRow.baseUrl,
+ id: providerRow.id,
+ type: providerRow.type,
+ },
+ };
+}
+
export function listModels(
raw: Database,
options: { keyword?: string; page: number; pageSize: number; providerId?: string },
diff --git a/src/server/routes/chat/send.ts b/src/server/routes/chat/send.ts
index 588f236..de05010 100644
--- a/src/server/routes/chat/send.ts
+++ b/src/server/routes/chat/send.ts
@@ -1,21 +1,19 @@
import type Database from "bun:sqlite";
import { createAgentUIStreamResponse, generateText, type UIMessage } from "ai";
-import { eq } from "drizzle-orm";
import type { RuntimeMode } from "../../../shared/api";
import type { Logger } from "../../logger";
import { createAlfredAgent } from "../../ai/agents/alfred-agent";
import { buildProviderRegistry } from "../../ai/registry";
-import { wrap } from "../../db/connection";
import {
createMessage,
getConversation,
updateConversation,
updateConversationTimestamp,
} from "../../db/conversations";
-import { models, providers } from "../../db/schema";
+import { getModelWithProvider } from "../../db/models";
import { createApiError, jsonResponse } from "../../helpers";
import { validateIdParam } from "../../middleware";
@@ -29,7 +27,7 @@ export async function handleSendChat(req: Request, db: Database, mode: RuntimeMo
let body: { conversationId?: string; messages?: UIMessage[] };
try {
body = (await req.json()) as typeof body;
- } catch (e) {
+ } catch (e: unknown) {
logger.warn({ error: e instanceof Error ? e.message : String(e) }, "请求 JSON 解析失败");
return jsonResponse(createApiError("Invalid JSON body", 400), { mode, status: 400 });
}
@@ -81,19 +79,13 @@ export async function handleSendChat(req: Request, db: Database, mode: RuntimeMo
let model;
try {
- const d = wrap(db);
- const modelRow = d.select().from(models).where(eq(models.id, conversation.modelId)).get();
- if (!modelRow) {
- return jsonResponse(createApiError(`模型不存在: ${conversation.modelId}`, 400), { mode, status: 400 });
- }
-
- const providerRow = d.select().from(providers).where(eq(providers.id, modelRow.providerId)).get();
- if (!providerRow) {
- return jsonResponse(createApiError(`供应商不存在: ${modelRow.providerId}`, 400), { mode, status: 400 });
+ const result = getModelWithProvider(db, conversation.modelId);
+ if ("error" in result) {
+ return jsonResponse(createApiError(result.error, result.status), { mode, status: result.status });
}
const registry = buildProviderRegistry(db);
- model = registry.languageModel(`${providerRow.id}:${modelRow.modelId}`);
+ model = registry.languageModel(`${result.provider.id}:${result.model.modelId}`);
} catch (e: unknown) {
const msg = e instanceof Error ? e.message : String(e);
return jsonResponse(createApiError(`模型初始化失败：${msg}`, 500), { mode, status: 500 });
diff --git a/src/server/routes/projects/update.ts b/src/server/routes/projects/update.ts
index f90d759..fcacfb5 100644
--- a/src/server/routes/projects/update.ts
+++ b/src/server/routes/projects/update.ts
@@ -25,10 +25,11 @@ export async function handleUpdateProject(
} catch (e: unknown) {
logger.warn({ error: e instanceof Error ? e.message : String(e) }, "请求 JSON 解析失败");
return jsonResponse(createApiError("Invalid JSON body", 400), { mode, status: 400 });
- return jsonResponse(createApiError("Invalid JSON body", 400), { mode, status: 400 });
}
- if (!body.name && !body.description && body.name !== "" && body.description !== "") {
+ const hasName = body.name !== undefined && body.name.trim() !== "";
+ const hasDescription = body.description !== undefined && body.description.trim() !== "";
+ if (!hasName && !hasDescription) {
return jsonResponse(createApiError("At least one of name or description is required", 400), { mode, status: 400 });
}
diff --git a/src/server/routes/providers/update.ts b/src/server/routes/providers/update.ts
index 4d7c94e..5a9205c 100644
--- a/src/server/routes/providers/update.ts
+++ b/src/server/routes/providers/update.ts
@@ -34,6 +34,13 @@ export async function handleUpdateProvider(
});
}
+ if (body.name === undefined && body.baseUrl === undefined && body.apiKey === undefined && body.type === undefined) {
+ return jsonResponse(createApiError("至少需要提供 name, baseUrl, apiKey 或 type 中的一个字段", 400), {
+ mode,
+ status: 400,
+ });
+ }
+
const result = updateProvider(db, validated.id, body, logger);
if ("error" in result) {
return jsonResponse(createApiError(result.error, result.status), { mode, status: result.status });
diff --git a/src/web/hooks/use-conversations.ts b/src/web/hooks/use-conversations.ts
index f1ce7f5..f417f7d 100644
--- a/src/web/hooks/use-conversations.ts
+++ b/src/web/hooks/use-conversations.ts
@@ -29,7 +29,7 @@ export async function fetchConversation(projectId: string, conversationId: strin
try {
const response = await fetch(`/api/projects/${projectId}/conversations/${conversationId}`);
return handleResponse(response, (data) => (data as ConversationResponse).conversation);
- } catch (err) {
+ } catch (err: unknown) {
logger.error("获取会话失败", {
conversationId,
error: err instanceof Error ? err.message : String(err),
@@ -61,7 +61,7 @@ export async function updateConversation(
method: "PATCH",
});
return handleResponse(response, (data) => (data as ConversationResponse).conversation);
- } catch (err) {
+ } catch (err: unknown) {
logger.error("更新会话失败", {
conversationId,
error: err instanceof Error ? err.message : String(err),
diff --git a/src/web/pages/models/components/ModelFormModal.tsx b/src/web/pages/models/components/ModelFormModal.tsx
index 3401bf8..e5595a8 100644
--- a/src/web/pages/models/components/ModelFormModal.tsx
+++ b/src/web/pages/models/components/ModelFormModal.tsx
@@ -109,7 +109,7 @@ export function ModelFormModal({
message.success("模型已创建");
}
onOpenChange(false);
- } catch (err) {
+ } catch (err: unknown) {
if (err instanceof Error) {
message.error(err.message);
}
@@ -136,7 +136,7 @@ export function ModelFormModal({
} else {
message.error(result.message);
}
- } catch (err) {
+ } catch (err: unknown) {
message.error((err as Error).message);
} finally {
setTesting(false);
diff --git a/src/web/pages/models/components/ModelTable.tsx b/src/web/pages/models/components/ModelTable.tsx
index 9c0825b..2464561 100644
--- a/src/web/pages/models/components/ModelTable.tsx
+++ b/src/web/pages/models/components/ModelTable.tsx
@@ -69,7 +69,7 @@ export function ModelTable({
try {
await onDelete(id);
message.success("模型已删除");
- } catch (err) {
+ } catch (err: unknown) {
message.error((err as Error).message);
}
};
diff --git a/src/web/pages/models/components/ProviderFormModal.tsx b/src/web/pages/models/components/ProviderFormModal.tsx
index 84d8194..a955415 100644
--- a/src/web/pages/models/components/ProviderFormModal.tsx
+++ b/src/web/pages/models/components/ProviderFormModal.tsx
@@ -83,7 +83,7 @@ export function ProviderFormModal({
message.success("供应商已创建");
}
onOpenChange(false);
- } catch (err) {
+ } catch (err: unknown) {
if (err instanceof Error) {
message.error(err.message);
}
@@ -105,7 +105,7 @@ export function ProviderFormModal({
} else {
message.error(result.message);
}
- } catch (err) {
+ } catch (err: unknown) {
if (err instanceof Error) {
message.error(err.message);
}
@@ -135,10 +135,18 @@ export function ProviderFormModal({
-
+
-
+
diff --git a/src/web/pages/models/components/ProviderTable.tsx b/src/web/pages/models/components/ProviderTable.tsx
index e4a8a58..bbe53dc 100644
--- a/src/web/pages/models/components/ProviderTable.tsx
+++ b/src/web/pages/models/components/ProviderTable.tsx
@@ -39,7 +39,7 @@ export function ProviderTable({ data, loading, onDelete, onEdit, onPageChange, p
try {
await onDelete(id);
message.success("供应商已删除");
- } catch (err) {
+ } catch (err: unknown) {
message.error((err as Error).message);
}
};
diff --git a/src/web/pages/models/index.tsx b/src/web/pages/models/index.tsx
index df6f8c6..420252c 100644
--- a/src/web/pages/models/index.tsx
+++ b/src/web/pages/models/index.tsx
@@ -111,7 +111,7 @@ export function ModelsPage() {
};
return (
-
+
+
): void {
if (level === "warn") this.messageApi.warning(message);
@@ -70,7 +72,9 @@ class BaseLogger implements Logger {
}
class ConsoleSink implements Sink {
- constructor(private isProduction: boolean) {}
+ constructor(private isProduction: boolean) {
+ // 仅存储配置，无需初始化操作
+ }
write(level: LogLevel, message: string, data: unknown, bindings: Record): void {
if (this.isProduction && LEVEL_ORDER[level] < LEVEL_ORDER.warn) return;
@@ -85,23 +89,31 @@ class ConsoleSink implements Sink {
}
}
-/* eslint-disable @typescript-eslint/no-empty-function */
class NoopLogger implements Logger {
child(_bindings: Record): Logger {
return this;
}
- debug(_message: string, _data?: unknown): void {}
+ debug(_message: string, _data?: unknown): void {
+ /* NoopLogger 实现 Logger 接口契约，有意静默丢弃所有日志 */
+ }
- error(_message: string, _data?: unknown): void {}
+ error(_message: string, _data?: unknown): void {
+ /* NoopLogger 实现 Logger 接口契约，有意静默丢弃所有日志 */
+ }
- info(_message: string, _data?: unknown): void {}
+ info(_message: string, _data?: unknown): void {
+ /* NoopLogger 实现 Logger 接口契约，有意静默丢弃所有日志 */
+ }
- setLevel(_level: LogLevel): void {}
+ setLevel(_level: LogLevel): void {
+ /* NoopLogger 实现 Logger 接口契约，有意静默丢弃所有日志 */
+ }
- warn(_message: string, _data?: unknown): void {}
+ warn(_message: string, _data?: unknown): void {
+ /* NoopLogger 实现 Logger 接口契约，有意静默丢弃所有日志 */
+ }
}
-/* eslint-enable @typescript-eslint/no-empty-function */
export class MemoryLogger implements Logger {
entries: Array<{ data?: unknown; level: LogLevel; message: string }> = [];
@@ -123,8 +135,9 @@ export class MemoryLogger implements Logger {
this.capture("info", message, data);
}
- /* eslint-disable-next-line @typescript-eslint/no-empty-function */
- setLevel(_level: LogLevel): void {}
+ setLevel(_level: LogLevel): void {
+ // MemoryLogger.setLevel 为接口兼容，无需实际过滤
+ }
warn(message: string, data?: unknown): void {
this.capture("warn", message, data);
diff --git a/tests/server/bootstrap-db.test.ts b/tests/server/bootstrap-db.test.ts
index 0ce1a21..64fcf24 100644
--- a/tests/server/bootstrap-db.test.ts
+++ b/tests/server/bootstrap-db.test.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/no-empty-function, @typescript-eslint/require-await */
+/* eslint-disable @typescript-eslint/require-await */
import { describe, expect, test } from "bun:test";
import { mkdirSync } from "node:fs";
import { tmpdir } from "node:os";
diff --git a/tests/setup.ts b/tests/setup.ts
index 92b6063..72ad5ac 100644
--- a/tests/setup.ts
+++ b/tests/setup.ts
@@ -3,8 +3,6 @@
* 后端测试无需 DOM 环境，前端测试依赖 jsdom 及 antd polyfill
*/
-/* eslint-disable @typescript-eslint/no-empty-function */
-
// 仅当前端测试需要时初始化 jsdom（所有测试共享 preload，后端测试也在此环境中运行）
import { JSDOM } from "jsdom";
diff --git a/tests/web/components/query-client-logging.test.tsx b/tests/web/components/query-client-logging.test.tsx
index 106dc30..6fddebd 100644
--- a/tests/web/components/query-client-logging.test.tsx
+++ b/tests/web/components/query-client-logging.test.tsx
@@ -30,7 +30,6 @@ describe("QueryClient MutationCache onError", () => {
mutate(
{ name: "test" },
{
- // eslint-disable-next-line @typescript-eslint/no-empty-function
onError: () => {},
},
);
diff --git a/tests/web/hooks/on-success-logging.test.tsx b/tests/web/hooks/on-success-logging.test.tsx
index 06a6697..4958de1 100644
--- a/tests/web/hooks/on-success-logging.test.tsx
+++ b/tests/web/hooks/on-success-logging.test.tsx
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-empty-function */
-
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import { render } from "@testing-library/react";
import { describe, expect, mock, test } from "bun:test";
diff --git a/tests/web/hooks/use-logger.test.ts b/tests/web/hooks/use-logger.test.ts
index df0084a..653ce86 100644
--- a/tests/web/hooks/use-logger.test.ts
+++ b/tests/web/hooks/use-logger.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-empty-function */
-
import { describe, expect, mock, test } from "bun:test";
import { createElement } from "react";
diff --git a/tests/web/utils/api.test.ts b/tests/web/utils/api.test.ts
index 40870f6..cb8d637 100644
--- a/tests/web/utils/api.test.ts
+++ b/tests/web/utils/api.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-empty-function */
import { describe, expect, mock, test } from "bun:test";
import { handleResponse, handleVoidResponse } from "../../../src/web/utils/api";
diff --git a/tests/web/utils/logger.test.ts b/tests/web/utils/logger.test.ts
index 3948d93..ae4f9ec 100644
--- a/tests/web/utils/logger.test.ts
+++ b/tests/web/utils/logger.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-empty-function */
-
import { describe, expect, mock, test } from "bun:test";
import type { Sink } from "../../../src/web/utils/logger";