1
0

refactor: 消除 es-toolkit/compat 依赖,isArray/isObject 替换为原生实现

This commit is contained in:
2026-05-19 14:57:56 +08:00
parent 7a635a0a9f
commit 8d8549d07f
14 changed files with 62 additions and 38 deletions

View File

@@ -1,5 +1,4 @@
import { isNumber, isPlainObject, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import { dirname, resolve } from "node:path";
import type { ConfigValidationIssue } from "./schema/issues";
@@ -151,7 +150,7 @@ function resolveTarget(
function validateConfig(config: RawProbeConfig): ConfigValidationIssue[] {
const issues: ConfigValidationIssue[] = [];
if (!isArray(config.targets) || config.targets.length === 0) {
if (!Array.isArray(config.targets) || config.targets.length === 0) {
issues.push(issue("required", "targets", "配置文件必须包含至少一个 target"));
return issues;
}

View File

@@ -1,6 +1,5 @@
import { DOMParser } from "@xmldom/xmldom";
import * as cheerio from "cheerio";
import { isArray } from "es-toolkit/compat";
import * as xpath from "xpath";
import type { CheckFailure } from "../types";
@@ -165,7 +164,7 @@ function parseJsonSource(source: unknown): ParsedJsonResult {
}
function xpathValue(result: unknown): unknown {
if (!isArray(result)) return result;
if (!Array.isArray(result)) return result;
if (result.length === 0) return undefined;
const node = (result as unknown[])[0]!;

View File

@@ -1,5 +1,4 @@
import { isString } from "es-toolkit";
import { isObject } from "es-toolkit/compat";
import type { CheckFailure } from "../types";
@@ -32,7 +31,7 @@ export function mismatchFailure(
export function truncateActual(value: unknown, maxLen = 200): unknown {
if (value === undefined || value === null) return value;
const str = isString(value) ? value : isObject(value) ? JSON.stringify(value) : undefined;
const str = isString(value) ? value : typeof value === "object" && value !== null ? JSON.stringify(value) : undefined;
if (str === undefined) return value;
if (str.length <= maxLen) return value;
return `${str.slice(0, maxLen)}…(共 ${str.length} 字符)`;

View File

@@ -1,5 +1,4 @@
import { isEmptyObject, isEqual, isNil, isPlainObject } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { CheckFailure, JsonValue } from "../types";
import type { ExpectResult, ValueMatcher } from "./types";
@@ -98,7 +97,7 @@ export function evaluateJsonPath(json: unknown, path: string): unknown {
if (current === null || current === undefined) return undefined;
current = (current as Record<string, unknown>)[bracketMatch[1]!];
const idx = parseInt(bracketMatch[2]!, 10);
if (!isArray(current) || idx >= current.length) return undefined;
if (!Array.isArray(current) || idx >= current.length) return undefined;
current = current[idx];
} else {
if (current === null || current === undefined) return undefined;
@@ -123,7 +122,7 @@ function compareNumber(
}
function isEmptyValue(value: unknown): boolean {
return isNil(value) || value === "" || (isArray(value) && value.length === 0) || isEmptyObject(value);
return isNil(value) || value === "" || (Array.isArray(value) && value.length === 0) || isEmptyObject(value);
}
function stringValue(actual: unknown, options: { stringifyNonString?: boolean }): string {

View File

@@ -1,6 +1,5 @@
import { DOMParser } from "@xmldom/xmldom";
import { isBoolean, isNumber, isPlainObject, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import * as xpath from "xpath";
import type { ConfigValidationIssue } from "../schema/issues";
@@ -19,7 +18,7 @@ export function isJsonValue(value: unknown): value is JsonValue {
if (value === null) return true;
if (isString(value) || isBoolean(value)) return true;
if (isNumber(value)) return Number.isFinite(value);
if (isArray(value)) return value.every(isJsonValue);
if (Array.isArray(value)) return value.every(isJsonValue);
if (isPlainObject(value)) return Object.values(value).every(isJsonValue);
return false;
}
@@ -29,7 +28,7 @@ export function isPlainRecord(value: unknown): value is Record<string, unknown>
}
export function validateContentRules(rules: unknown, path: string, targetName?: string): ConfigValidationIssue[] {
if (!isArray(rules)) return [issue("invalid-type", path, "必须为数组", targetName)];
if (!Array.isArray(rules)) return [issue("invalid-type", path, "必须为数组", targetName)];
return rules.flatMap((rule, index) => validateContentRule(rule, `${path}[${index}]`, targetName));
}

View File

@@ -1,6 +1,5 @@
import { SQL } from "bun";
import { isError } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { CheckResult, RawTargetConfig } from "../../types";
import type { CheckerContext, CheckerDefinition, CheckerValidationInput, ResolveContext } from "../types";
@@ -126,7 +125,7 @@ export class DbChecker implements CheckerDefinition<ResolvedDbTarget> {
durationMs,
failure: durationResult.failure,
matched: false,
statusDetail: `${isArray(rows) ? rows.length : 0} rows`,
statusDetail: `${Array.isArray(rows) ? rows.length : 0} rows`,
targetId: t.id,
timestamp,
};
@@ -134,13 +133,13 @@ export class DbChecker implements CheckerDefinition<ResolvedDbTarget> {
// rowCount 断言
if (t.expect?.rowCount) {
const rowCountResult = checkRowCount(isArray(rows) ? rows.length : 0, t.expect.rowCount);
const rowCountResult = checkRowCount(Array.isArray(rows) ? rows.length : 0, t.expect.rowCount);
if (!rowCountResult.matched) {
return {
durationMs,
failure: rowCountResult.failure,
matched: false,
statusDetail: `${isArray(rows) ? rows.length : 0} rows`,
statusDetail: `${Array.isArray(rows) ? rows.length : 0} rows`,
targetId: t.id,
timestamp,
};
@@ -155,7 +154,7 @@ export class DbChecker implements CheckerDefinition<ResolvedDbTarget> {
durationMs,
failure: rowsResult.failure,
matched: false,
statusDetail: `${isArray(rows) ? rows.length : 0} rows`,
statusDetail: `${Array.isArray(rows) ? rows.length : 0} rows`,
targetId: t.id,
timestamp,
};
@@ -163,7 +162,7 @@ export class DbChecker implements CheckerDefinition<ResolvedDbTarget> {
}
if (t.expect?.result && t.expect.result.length > 0) {
const rowCount = isArray(rows) ? rows.length : 0;
const rowCount = Array.isArray(rows) ? rows.length : 0;
const resultCheck = checkContentRules({ rowCount, rows }, t.expect.result, { path: "result", phase: "result" });
if (!resultCheck.matched) {
return {
@@ -181,7 +180,7 @@ export class DbChecker implements CheckerDefinition<ResolvedDbTarget> {
durationMs,
failure: null,
matched: true,
statusDetail: `${isArray(rows) ? rows.length : 0} rows`,
statusDetail: `${Array.isArray(rows) ? rows.length : 0} rows`,
targetId: t.id,
timestamp,
};

View File

@@ -1,5 +1,4 @@
import { isPlainObject } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { ExpectResult, KeyValueExpect, ValueMatcher } from "../../expect/types";
@@ -16,7 +15,7 @@ export function checkRowCount(actual: number, matcher: ValueMatcher): ExpectResu
}
export function checkRows(rows: unknown, rules: KeyValueExpect[]): ExpectResult {
if (!isArray(rows)) {
if (!Array.isArray(rows)) {
return {
failure: mismatchFailure("row", "rows", rules, rows, "查询结果不是数组"),
matched: false,

View File

@@ -1,5 +1,4 @@
import { isPlainObject, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { ConfigValidationIssue } from "../../schema/issues";
import type { CheckerValidationInput } from "../types";
@@ -54,7 +53,7 @@ function validateDbExpect(target: Record<string, unknown>, path: string): Config
}
if (expect["rows"] !== undefined) {
if (!isArray(expect["rows"])) {
if (!Array.isArray(expect["rows"])) {
issues.push(issue("invalid-type", joinPath(expectPath, "rows"), "必须为数组", targetName));
} else {
issues.push(...collectRowExpects(expect["rows"], joinPath(expectPath, "rows"), targetName));

View File

@@ -1,5 +1,4 @@
import { isError } from "es-toolkit";
import { isObject } from "es-toolkit/compat";
import type { CheckResult, RawTargetConfig } from "../../types";
import type { CheckerContext, CheckerDefinition, CheckerValidationInput, ResolveContext } from "../types";
@@ -161,7 +160,10 @@ function buildRedirectInit(init: RequestInit, statusCode: number, fromUrl: strin
const method = init.method?.toUpperCase();
if (statusCode === 303 || ((statusCode === 301 || statusCode === 302) && method === "POST")) {
const headers = isObject(init.headers) ? { ...(init.headers as Record<string, string>) } : undefined;
const headers =
typeof init.headers === "object" && init.headers !== null
? { ...(init.headers as Record<string, string>) }
: undefined;
if (headers) {
for (const key of Object.keys(headers)) {
const lower = key.toLowerCase();
@@ -176,7 +178,7 @@ function buildRedirectInit(init: RequestInit, statusCode: number, fromUrl: strin
try {
const fromOrigin = new URL(fromUrl).origin;
const toOrigin = new URL(toUrl).origin;
if (fromOrigin !== toOrigin && isObject(newInit.headers)) {
if (fromOrigin !== toOrigin && typeof newInit.headers === "object" && newInit.headers !== null) {
const headers = { ...(newInit.headers as Record<string, string>) };
for (const key of Object.keys(headers)) {
if (SENSITIVE_HEADERS.has(key.toLowerCase())) {

View File

@@ -1,5 +1,4 @@
import { isNumber, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { ConfigValidationIssue } from "../../schema/issues";
import type { CheckerValidationInput } from "../types";
@@ -76,7 +75,7 @@ function validateHttpExpect(target: Record<string, unknown>, path: string): Conf
issues.push(...validateContentRules(expect["body"], joinPath(expectPath, "body"), targetName));
}
if (isArray(expect["status"])) {
if (Array.isArray(expect["status"])) {
issues.push(...validateStatusValues(expect["status"], joinPath(expectPath, "status"), targetName));
}

View File

@@ -1,5 +1,4 @@
import { isBoolean, isNumber, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { ConfigValidationIssue } from "../../schema/issues";
import type { CheckerValidationInput } from "../types";
@@ -73,7 +72,7 @@ function validateLlmExpect(
const issues: ConfigValidationIssue[] = [];
const expectPath = joinPath(path, "expect");
if (isArray(expect["status"])) {
if (Array.isArray(expect["status"])) {
issues.push(...validateStatusValues(expect["status"], joinPath(expectPath, "status"), targetName));
}
if (expect["headers"] !== undefined) {
@@ -144,7 +143,7 @@ function validateLlmOptions(options: unknown, path: string, targetName?: string)
}
if (options["stopSequences"] !== undefined) {
if (!isArray(options["stopSequences"])) {
if (!Array.isArray(options["stopSequences"])) {
issues.push(issue("invalid-type", joinPath(path, "stopSequences"), "必须为字符串数组", targetName));
} else {
for (let i = 0; i < options["stopSequences"].length; i++) {

View File

@@ -2,7 +2,6 @@ import type { ErrorObject } from "ajv";
import Ajv from "ajv";
import { isPlainObject, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { CheckerRegistry } from "../runner/registry";
import type { ConfigValidationIssue } from "./issues";
@@ -34,7 +33,7 @@ export function validateProbeConfigContract(
if (isPlainObject(config)) {
const configRecord = config as Record<string, unknown>;
const targetsValue: unknown = configRecord["targets"];
if (!isArray(targetsValue))
if (!Array.isArray(targetsValue))
return issues.length > 0 ? { config: null, issues } : { config: config as RawProbeConfig, issues: [] };
const targets = targetsValue;
for (let i = 0; i < targets.length; i++) {
@@ -142,7 +141,7 @@ function targetDisplayNameFromPath(root: unknown, path: string): string | undefi
if (!match || !isPlainObject(root)) return undefined;
const rootRecord = root as Record<string, unknown>;
const targetsValue: unknown = rootRecord["targets"];
if (!isArray(targetsValue)) return undefined;
if (!Array.isArray(targetsValue)) return undefined;
const target: unknown = targetsValue[Number(match[1])];
if (!isPlainObject(target)) return undefined;
const targetRecord = target as Record<string, unknown>;

View File

@@ -1,5 +1,4 @@
import { isBoolean, isNumber, isPlainObject, isString } from "es-toolkit";
import { isArray } from "es-toolkit/compat";
import type { ConfigValidationIssue } from "./schema/issues";
import type { VariableValue } from "./types";
@@ -66,7 +65,7 @@ export function resolveVariables(config: unknown): { config: unknown; issues: Co
}
const configRecord = config as Record<string, unknown>;
const rawTargets: unknown = configRecord["targets"];
if (!isArray(rawTargets)) {
if (!Array.isArray(rawTargets)) {
return { config, issues };
}
@@ -76,7 +75,7 @@ export function resolveVariables(config: unknown): { config: unknown; issues: Co
function describeInvalidVariableValue(value: unknown): string {
if (value === null) return "null";
if (isArray(value)) return "array";
if (Array.isArray(value)) return "array";
return typeof value;
}
@@ -156,7 +155,7 @@ function resolveValue(
if (isString(value)) {
return replaceStringValue(value, variables, issues, { ...context, path });
}
if (isArray(value)) {
if (Array.isArray(value)) {
return value.map((item, index) =>
resolveValue(item, `${path}[${index}]`, variables, issues, { ...context, path: `${path}[${index}]` }),
);