refactor: 清理 checker 遗留边界

2026-05-13 12:53:03 +08:00
parent 7b20b59b79
commit aade0bbff7
6 changed files with 85 additions and 196 deletions
--- a/tests/server/checker/runner/http/expect.test.ts
+++ b/tests/server/checker/runner/http/expect.test.ts
@@ -1,152 +1,66 @@
 import { describe, expect, test } from "bun:test";

-import { checkHttpExpect, checkStatus } from "../../../../../src/server/checker/runner/http/expect";
+import { checkHeaders, checkStatus } from "../../../../../src/server/checker/runner/http/expect";

-function obs(
-  overrides: { body?: null | string; durationMs?: number; headers?: Record<string, string>; statusCode?: number } = {},
-) {
-  return {
-    body: overrides.body ?? "",
-    durationMs: overrides.durationMs ?? 100,
-    headers: overrides.headers ?? {},
-    statusCode: overrides.statusCode ?? 200,
-  };
-}
-
-describe("checkHttpExpect", () => {
-  test("无 expect 配置时默认检查 status [200] 匹配成功", () => {
-    const r = checkHttpExpect(obs().statusCode, obs().headers, obs().body, obs().durationMs);
-    expect(r.matched).toBe(true);
-    expect(r.failure).toBeNull();
+describe("checkHeaders", () => {
+  test("未配置 headers expect 时匹配成功", () => {
+    const result = checkHeaders({});
+    expect(result.matched).toBe(true);
+    expect(result.failure).toBeNull();
  });

-  test("无 expect 配置时 status 非 200 匹配失败", () => {
-    const r = checkHttpExpect(500, {}, "", 100);
-    expect(r.matched).toBe(false);
-    expect(r.failure).not.toBeNull();
-    expect(r.failure!.phase).toBe("status");
-    expect(r.failure!.kind).toBe("mismatch");
+  test("字符串格式按等值匹配", () => {
+    const headers = { "content-type": "application/json", "x-api": "v1" };
+
+    expect(checkHeaders(headers, { "content-type": "application/json" }).matched).toBe(true);
+    expect(checkHeaders(headers, { "content-type": "text/html" }).matched).toBe(false);
  });

-  test("status 匹配指定状态码", () => {
-    const cfg = { status: [200, 301] };
-    expect(checkHttpExpect(200, {}, "", 100, cfg).matched).toBe(true);
-    expect(checkHttpExpect(301, {}, "", 100, cfg).matched).toBe(true);
-    expect(checkHttpExpect(404, {}, "", 100, cfg).matched).toBe(false);
+  test("header 名称按小写响应头匹配", () => {
+    const headers = { "content-type": "application/json" };
+
+    expect(checkHeaders(headers, { "Content-Type": "application/json" }).matched).toBe(true);
  });

-  test("status 不匹配返回 phase=status 的失败", () => {
-    const r = checkHttpExpect(503, {}, "", 100, { status: [200] });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("status");
-    expect(r.failure!.expected).toEqual([200]);
-    expect(r.failure!.actual).toBe(503);
+  test("操作符格式匹配", () => {
+    const headers = { "content-type": "application/json" };
+
+    expect(checkHeaders(headers, { "content-type": { contains: "json" } }).matched).toBe(true);
+    expect(checkHeaders(headers, { "content-type": { match: "^application/" } }).matched).toBe(true);
+    expect(checkHeaders(headers, { "content-type": { contains: "xml" } }).matched).toBe(false);
  });

-  test("duration 在限制内匹配成功", () => {
-    const r = checkHttpExpect(200, {}, "", 50, { maxDurationMs: 100 });
-    expect(r.matched).toBe(true);
+  test("缺失 header 默认返回失败", () => {
+    const result = checkHeaders({}, { "x-missing": "value" });
+
+    expect(result.matched).toBe(false);
+    expect(result.failure!.phase).toBe("headers");
+    expect(result.failure!.kind).toBe("mismatch");
  });

-  test("duration 超过限制匹配失败", () => {
-    const r = checkHttpExpect(200, {}, "", 200, { maxDurationMs: 100 });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("duration");
-  });
+  test("缺失 header 且 exists=false 时匹配成功", () => {
+    const result = checkHeaders({}, { "x-missing": { exists: false } });

-  test("duration 恰好等于限制匹配成功", () => {
-    const r = checkHttpExpect(200, {}, "", 100, { maxDurationMs: 100 });
-    expect(r.matched).toBe(true);
-  });
-
-  test("headers 字符串格式检查（等于）", () => {
-    const h = { "content-type": "application/json", "x-api": "v1" };
-    expect(checkHttpExpect(200, h, "", 100, { headers: { "content-type": "application/json" } }).matched).toBe(true);
-    expect(checkHttpExpect(200, h, "", 100, { headers: { "content-type": "text/html" } }).matched).toBe(false);
-  });
-
-  test("headers 操作符格式检查", () => {
-    const h = { "content-type": "application/json" };
-    expect(checkHttpExpect(200, h, "", 100, { headers: { "content-type": { contains: "json" } } }).matched).toBe(true);
-    expect(checkHttpExpect(200, h, "", 100, { headers: { "content-type": { match: "^application/" } } }).matched).toBe(
-      true,
-    );
-    expect(checkHttpExpect(200, h, "", 100, { headers: { "content-type": { contains: "xml" } } }).matched).toBe(false);
-  });
-
-  test("headers 大小写不敏感匹配", () => {
-    const h = { "content-type": "application/json" };
-    expect(checkHttpExpect(200, h, "", 100, { headers: { "Content-Type": "application/json" } }).matched).toBe(true);
-  });
-
-  test("headers 不存在时返回失败", () => {
-    const r = checkHttpExpect(200, {}, "", 100, { headers: { "x-missing": "value" } });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("headers");
-  });
-
-  test("body 规则数组按顺序检查", () => {
-    const body = JSON.stringify({ count: 5, status: "ok" });
-    const r = checkHttpExpect(200, {}, body, 100, {
-      body: [{ contains: "ok" }, { json: { gte: 1, path: "$.count" } }],
-    });
-    expect(r.matched).toBe(true);
-  });
-
-  test("body 第一条规则失败立即返回", () => {
-    const r = checkHttpExpect(200, {}, "hello world", 100, {
-      body: [{ contains: "missing" }, { contains: "hello" }],
-    });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.path).toBe("body[0]");
-  });
-
-  test("body 为 null 但有 body 规则时报错", () => {
-    const r = checkHttpExpect(200, {}, null, 100, { body: [{ contains: "test" }] });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.kind).toBe("error");
-  });
-
-  test("完整流水线 status->headers->body->duration 全部通过", () => {
-    const r = checkHttpExpect(200, { "content-type": "application/json" }, JSON.stringify({ status: "healthy" }), 50, {
-      body: [{ json: { equals: "healthy", path: "$.status" } }],
-      headers: { "content-type": { contains: "json" } },
-      maxDurationMs: 100,
-      status: [200],
-    });
-    expect(r.matched).toBe(true);
-    expect(r.failure).toBeNull();
-  });
-
-  test("完整流水线 status 和 headers 通过但 duration 失败", () => {
-    const r = checkHttpExpect(200, {}, "", 500, { maxDurationMs: 100, status: [200] });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("duration");
-  });
-
-  test("完整流水线 status 通过但 headers 失败", () => {
-    const r = checkHttpExpect(200, { "x-api": "v1" }, "", 50, {
-      headers: { "x-api": "v2" },
-      maxDurationMs: 100,
-      status: [200],
-    });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("headers");
-  });
-
-  test("完整流水线 status/headers 通过但 body 失败", () => {
-    const r = checkHttpExpect(200, { "content-type": "text/plain" }, "error occurred", 50, {
-      body: [{ contains: "success" }],
-      headers: { "content-type": "text/plain" },
-      maxDurationMs: 100,
-      status: [200],
-    });
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("body");
+    expect(result.matched).toBe(true);
+    expect(result.failure).toBeNull();
  });
 });

 describe("checkStatus 范围匹配", () => {
+  test("无 expect 配置时默认 status [200] 可由调用方使用 checkStatus 表达", () => {
+    const result = checkStatus(200, [200]);
+    expect(result.matched).toBe(true);
+    expect(result.failure).toBeNull();
+  });
+
+  test("status 不匹配返回 phase=status 的失败", () => {
+    const result = checkStatus(503, [200]);
+    expect(result.matched).toBe(false);
+    expect(result.failure!.phase).toBe("status");
+    expect(result.failure!.expected).toEqual([200]);
+    expect(result.failure!.actual).toBe(503);
+  });
+
  test("2xx 范围匹配 200", () => {
    expect(checkStatus(200, ["2xx"]).matched).toBe(true);
  });
@@ -163,11 +77,11 @@ describe("checkStatus 范围匹配", () => {
    expect(checkStatus(503, ["5xx"]).matched).toBe(true);
  });

-  test("混合精确值与范围模式 — 精确命中", () => {
+  test("混合精确值与范围模式命中精确值", () => {
    expect(checkStatus(301, ["2xx", 301]).matched).toBe(true);
  });

-  test("混合精确值与范围模式 — 范围命中", () => {
+  test("混合精确值与范围模式命中范围", () => {
    expect(checkStatus(204, ["2xx", 301]).matched).toBe(true);
  });

@@ -180,12 +94,6 @@ describe("checkStatus 范围匹配", () => {
    expect(checkStatus(404, [200, 201]).matched).toBe(false);
  });

-  test("范围匹配失败返回 phase=status 的 failure", () => {
-    const r = checkStatus(404, ["2xx"]);
-    expect(r.matched).toBe(false);
-    expect(r.failure!.phase).toBe("status");
-  });
-
  test("1xx 范围匹配 101", () => {
    expect(checkStatus(101, ["1xx"]).matched).toBe(true);
  });