lanyuanxiaoyao
ef3fa6a06a
- 在 ResourceValidator 中添加 validate_template_vars 方法 - 在验证阶段检查用户是否提供了模板所需的必需变量 - 缺少必需变量时返回 ERROR 级别错误 - 添加 9 个单元测试用例验证功能 - 同步更新 OpenSpec 规格文档
240 lines
9.4 KiB
Python
240 lines
9.4 KiB
Python
"""
|
|
资源验证器单元测试
|
|
|
|
测试 ResourceValidator 的图片和模板文件验证功能
|
|
"""
|
|
|
|
import pytest
|
|
from pathlib import Path
|
|
from validators.resource import ResourceValidator
|
|
|
|
|
|
class TestResourceValidator:
|
|
"""ResourceValidator 测试类"""
|
|
|
|
def test_init(self, temp_dir):
|
|
"""测试初始化"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
assert validator.yaml_dir == temp_dir
|
|
assert validator.template_dir is None
|
|
|
|
def test_init_with_template_dir(self, temp_dir):
|
|
"""测试带模板目录初始化"""
|
|
template_dir = temp_dir / "templates"
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
assert validator.template_dir == template_dir
|
|
|
|
|
|
class TestValidateImage:
|
|
"""validate_image 方法测试"""
|
|
|
|
def test_existing_image(self, temp_dir, sample_image):
|
|
"""测试存在的图片文件"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
elem = type("Element", (), {"src": sample_image.name})()
|
|
issues = validator.validate_image(elem, 1, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_nonexistent_image(self, temp_dir):
|
|
"""测试不存在的图片文件"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
elem = type("Element", (), {"src": "nonexistent.png"})()
|
|
issues = validator.validate_image(elem, 1, 1)
|
|
assert len(issues) == 1
|
|
assert issues[0].level == "ERROR"
|
|
assert issues[0].code == "IMAGE_FILE_NOT_FOUND"
|
|
|
|
def test_image_with_absolute_path(self, temp_dir, sample_image):
|
|
"""测试绝对路径图片"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
elem = type("Element", (), {"src": str(sample_image)})()
|
|
issues = validator.validate_image(elem, 1, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_image_without_src_attribute(self, temp_dir):
|
|
"""测试没有 src 属性的元素"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
elem = type("Element", (), {})() # 没有 src 属性
|
|
issues = validator.validate_image(elem, 1, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_image_with_empty_src(self, temp_dir):
|
|
"""测试空 src 字符串"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
elem = type("Element", (), {"src": ""})()
|
|
issues = validator.validate_image(elem, 1, 1)
|
|
assert len(issues) == 0
|
|
|
|
|
|
class TestValidateTemplate:
|
|
"""validate_template 方法测试"""
|
|
|
|
def test_slide_without_template(self, temp_dir):
|
|
"""测试不使用模板的幻灯片"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
slide_data = {} # 没有 template 字段
|
|
issues = validator.validate_template(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_template_with_dir_not_specified(self, temp_dir):
|
|
"""测试使用模板但未指定模板目录"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=None)
|
|
slide_data = {"template": "title-slide"}
|
|
issues = validator.validate_template(slide_data, 1)
|
|
assert len(issues) == 1
|
|
assert issues[0].level == "ERROR"
|
|
assert issues[0].code == "TEMPLATE_DIR_NOT_SPECIFIED"
|
|
|
|
def test_nonexistent_template_file(self, temp_dir):
|
|
"""测试不存在的模板文件"""
|
|
template_dir = temp_dir / "templates"
|
|
template_dir.mkdir()
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
slide_data = {"template": "nonexistent"}
|
|
issues = validator.validate_template(slide_data, 1)
|
|
assert len(issues) == 1
|
|
assert issues[0].level == "ERROR"
|
|
assert issues[0].code == "TEMPLATE_FILE_NOT_FOUND"
|
|
|
|
def test_valid_template_file(self, sample_template):
|
|
"""测试有效的模板文件"""
|
|
validator = ResourceValidator(
|
|
yaml_dir=sample_template.parent, template_dir=sample_template
|
|
)
|
|
slide_data = {"template": "title-slide"}
|
|
issues = validator.validate_template(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_template_with_yaml_extension(self, temp_dir):
|
|
"""测试带 .yaml 扩展名的模板"""
|
|
template_dir = temp_dir / "templates"
|
|
template_dir.mkdir()
|
|
(template_dir / "test.yaml").write_text("vars: []\nelements: []")
|
|
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
slide_data = {"template": "test.yaml"}
|
|
issues = validator.validate_template(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_invalid_template_structure(self, temp_dir):
|
|
"""测试无效的模板结构"""
|
|
template_dir = temp_dir / "templates"
|
|
template_dir.mkdir()
|
|
# 创建缺少 elements 字段的无效模板
|
|
(template_dir / "invalid.yaml").write_text("vars: []")
|
|
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
slide_data = {"template": "invalid"}
|
|
issues = validator.validate_template(slide_data, 1)
|
|
assert len(issues) == 1
|
|
assert issues[0].level == "ERROR"
|
|
assert issues[0].code == "TEMPLATE_STRUCTURE_ERROR"
|
|
|
|
|
|
class TestValidateTemplateVars:
|
|
"""validate_template_vars 方法测试"""
|
|
|
|
def test_slide_without_template(self, temp_dir):
|
|
"""测试不使用模板的幻灯片"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir)
|
|
slide_data = {}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_template_with_dir_not_specified(self, temp_dir):
|
|
"""测试使用模板但未指定模板目录"""
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=None)
|
|
slide_data = {"template": "title-slide"}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_provide_all_required_vars(self, sample_template):
|
|
"""测试提供所有必需变量时验证通过"""
|
|
validator = ResourceValidator(
|
|
yaml_dir=sample_template.parent, template_dir=sample_template
|
|
)
|
|
slide_data = {
|
|
"template": "title-slide",
|
|
"vars": {"title": "Hello", "subtitle": "World"},
|
|
}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_missing_required_var(self, sample_template):
|
|
"""测试缺少必需变量时验证失败"""
|
|
validator = ResourceValidator(
|
|
yaml_dir=sample_template.parent, template_dir=sample_template
|
|
)
|
|
slide_data = {"template": "title-slide", "vars": {"subtitle": "World"}}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 1
|
|
assert issues[0].level == "ERROR"
|
|
assert issues[0].code == "MISSING_TEMPLATE_REQUIRED_VARS"
|
|
assert "title" in issues[0].message
|
|
|
|
def test_multiple_required_vars_partial_missing(self, temp_dir):
|
|
"""测试多个必需变量部分缺失"""
|
|
template_dir = temp_dir / "templates"
|
|
template_dir.mkdir()
|
|
template_content = """vars:
|
|
- name: title
|
|
required: true
|
|
- name: subtitle
|
|
required: true
|
|
- name: author
|
|
required: false
|
|
elements: []
|
|
"""
|
|
(template_dir / "multi-var.yaml").write_text(template_content)
|
|
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
slide_data = {"template": "multi-var", "vars": {"title": "Hello"}}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 1
|
|
assert issues[0].level == "ERROR"
|
|
assert "subtitle" in issues[0].message
|
|
|
|
def test_optional_var_missing(self, sample_template):
|
|
"""测试可选变量缺失时验证通过"""
|
|
validator = ResourceValidator(
|
|
yaml_dir=sample_template.parent, template_dir=sample_template
|
|
)
|
|
slide_data = {"template": "title-slide", "vars": {"title": "Hello"}}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_template_with_no_required_vars(self, temp_dir):
|
|
"""测试模板没有必需变量时"""
|
|
template_dir = temp_dir / "templates"
|
|
template_dir.mkdir()
|
|
template_content = """vars:
|
|
- name: subtitle
|
|
required: false
|
|
elements: []
|
|
"""
|
|
(template_dir / "optional-only.yaml").write_text(template_content)
|
|
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
slide_data = {"template": "optional-only", "vars": {}}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_nonexistent_template_file(self, temp_dir):
|
|
"""测试模板文件不存在时不报错（由 validate_template 处理）"""
|
|
template_dir = temp_dir / "templates"
|
|
template_dir.mkdir()
|
|
validator = ResourceValidator(yaml_dir=temp_dir, template_dir=template_dir)
|
|
slide_data = {"template": "nonexistent"}
|
|
issues = validator.validate_template_vars(slide_data, 1)
|
|
assert len(issues) == 0
|
|
|
|
def test_error_location_contains_slide_number(self, sample_template):
|
|
"""测试错误信息包含幻灯片位置"""
|
|
validator = ResourceValidator(
|
|
yaml_dir=sample_template.parent, template_dir=sample_template
|
|
)
|
|
slide_data = {"template": "title-slide", "vars": {}}
|
|
issues = validator.validate_template_vars(slide_data, 5)
|
|
assert len(issues) == 1
|
|
assert "幻灯片 5" in issues[0].location
|