From ec14ca244bf0b0d14bc2af6dd97918d9146ce1f3 Mon Sep 17 00:00:00 2001 From: lanyuanxiaoyao Date: Thu, 4 May 2023 14:31:17 +0800 Subject: [PATCH] =?UTF-8?q?fix(yarn-query):=20=E4=BF=AE=E5=A4=8D=E6=B2=A1?= =?UTF-8?q?=E6=9C=89=E5=85=B3=E9=97=AD=E7=9A=84=20close?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../service/yarn/service/impl/JobServiceImpl.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/service-yarn-query/src/main/java/com/lanyuanxiaoyao/service/yarn/service/impl/JobServiceImpl.java b/service-yarn-query/src/main/java/com/lanyuanxiaoyao/service/yarn/service/impl/JobServiceImpl.java index 7e85378..212483e 100644 --- a/service-yarn-query/src/main/java/com/lanyuanxiaoyao/service/yarn/service/impl/JobServiceImpl.java +++ b/service-yarn-query/src/main/java/com/lanyuanxiaoyao/service/yarn/service/impl/JobServiceImpl.java @@ -2,6 +2,7 @@ package com.lanyuanxiaoyao.service.yarn.service.impl; import cn.hutool.core.util.StrUtil; import cn.hutool.core.util.URLUtil; +import cn.hutool.http.HttpResponse; import cn.hutool.http.HttpUtil; import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; @@ -42,8 +43,9 @@ public class JobServiceImpl implements JobService { @Override public ImmutableList list() throws JsonProcessingException { String queryUrl = URLUtil.completeUrl(yarnConfiguration.getWebUrl(), "/ws/v1/cluster/apps"); - String body = HttpUtil.createGet(queryUrl).setMaxRedirectCount(10).execute().body(); - return mapper.readValue(body, ApplicationsListResponse.class).getApps().getApp(); + try (HttpResponse response = HttpUtil.createGet(queryUrl).setMaxRedirectCount(10).execute()) { + return mapper.readValue(response.body(), ApplicationsListResponse.class).getApps().getApp(); + } } @Cacheable(value = "job-list", sync = true, key = "#{methodName+name}") @@ -69,7 +71,8 @@ public class JobServiceImpl implements JobService { @Override public YarnApplication detail(String applicationId) throws JsonProcessingException { String queryUrl = URLUtil.completeUrl(yarnConfiguration.getWebUrl(), "/ws/v1/cluster/apps/" + applicationId); - String body = HttpUtil.createGet(queryUrl).setMaxRedirectCount(10).execute().body(); - return mapper.readValue(body, ApplicationDetailResponse.class).getApp(); + try (HttpResponse response = HttpUtil.createGet(queryUrl).setMaxRedirectCount(10).execute()) { + return mapper.readValue(response.body(), ApplicationDetailResponse.class).getApp(); + } } }