From 09fd6f64c527e6a822c4e17dc4e61b8fdee28189 Mon Sep 17 00:00:00 2001 From: lw0090 Date: Sun, 19 Apr 2020 21:33:07 +0800 Subject: [PATCH] [HUDI-800] Fix Metrics getReporter().close() throws NPE. (#1529) --- .../src/main/java/org/apache/hudi/metrics/Metrics.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java b/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java index b62279e3b..598091162 100644 --- a/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java +++ b/hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java @@ -52,9 +52,11 @@ public class Metrics { Runtime.getRuntime().addShutdownHook(new Thread(() -> { try { reporter.report(); - getReporter().close(); + if (getReporter() != null) { + getReporter().close(); + } } catch (Exception e) { - e.printStackTrace(); + LOG.warn("Error while closing reporter", e); } })); }