From 0a07752dc03c51e16d7bb4239523b0181d819708 Mon Sep 17 00:00:00 2001
From: Prashant Wason <pwason@uber.com>
Date: Mon, 13 Jan 2020 11:38:59 -0800
Subject: [PATCH] [HUDI-527] scalastyle-maven-plugin moved to pluginManagement
 as it is only used in hoodie-spark and hoodie-cli modules.

This fixes compile warnings as well as unnecessary plugin invocation for most of the modules which do not have scala code.
---
 hudi-cli/pom.xml   |  7 +++++++
 hudi-spark/pom.xml |  4 ++++
 pom.xml            | 46 +++++++++++++++++++++++-----------------------
 3 files changed, 34 insertions(+), 23 deletions(-)

diff --git a/hudi-cli/pom.xml b/hudi-cli/pom.xml
index 62b55de4d..47f7c7f93 100644
--- a/hudi-cli/pom.xml
+++ b/hudi-cli/pom.xml
@@ -110,6 +110,13 @@
         <groupId>org.apache.rat</groupId>
         <artifactId>apache-rat-plugin</artifactId>
       </plugin>
+      <plugin>
+        <groupId>org.scalastyle</groupId>
+        <artifactId>scalastyle-maven-plugin</artifactId>
+        <configuration>
+          <includeTestSourceDirectory>false</includeTestSourceDirectory>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 
diff --git a/hudi-spark/pom.xml b/hudi-spark/pom.xml
index d69954a18..e83d96de2 100644
--- a/hudi-spark/pom.xml
+++ b/hudi-spark/pom.xml
@@ -140,6 +140,10 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.scalastyle</groupId>
+        <artifactId>scalastyle-maven-plugin</artifactId>
+      </plugin>
     </plugins>
   </build>
 
diff --git a/pom.xml b/pom.xml
index d4d47c0bb..58355acc6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -154,29 +154,6 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <groupId>org.scalastyle</groupId>
-        <artifactId>scalastyle-maven-plugin</artifactId>
-        <version>1.0.0</version>
-        <configuration>
-          <verbose>false</verbose>
-          <failOnViolation>true</failOnViolation>
-          <includeTestSourceDirectory>true</includeTestSourceDirectory>
-          <failOnWarning>false</failOnWarning>
-          <sourceDirectory>${project.basedir}/src/main/scala</sourceDirectory>
-          <testSourceDirectory>${project.basedir}/src/test/scala</testSourceDirectory>
-          <configLocation>${main.basedir}/style/scalastyle.xml</configLocation>
-          <outputEncoding>UTF-8</outputEncoding>
-        </configuration>
-        <executions>
-          <execution>
-            <phase>compile</phase>
-            <goals>
-              <goal>check</goal>
-            </goals>
-          </execution>
-        </executions>
-      </plugin>
 <!--
       See https://jira.apache.org/jira/browse/HUDI-304
       <plugin>
@@ -387,6 +364,29 @@
             </execution>
           </executions>
         </plugin>
+        <plugin>
+          <groupId>org.scalastyle</groupId>
+          <artifactId>scalastyle-maven-plugin</artifactId>
+          <version>1.0.0</version>
+          <configuration>
+            <verbose>false</verbose>
+            <failOnViolation>true</failOnViolation>
+            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+            <failOnWarning>false</failOnWarning>
+            <sourceDirectory>${project.basedir}/src/main/scala</sourceDirectory>
+            <testSourceDirectory>${project.basedir}/src/test/scala</testSourceDirectory>
+            <configLocation>${main.basedir}/style/scalastyle.xml</configLocation>
+            <outputEncoding>UTF-8</outputEncoding>
+          </configuration>
+          <executions>
+            <execution>
+              <phase>compile</phase>
+              <goals>
+                <goal>check</goal>
+              </goals>
+            </execution>
+          </executions>
+        </plugin>
       </plugins>
     </pluginManagement>
   </build>