From 0e8461e9abc97537954a2c1dd716aed53e52dc62 Mon Sep 17 00:00:00 2001 From: xiarixiaoyao Date: Sat, 13 Nov 2021 09:12:33 +0800 Subject: [PATCH] [HUDI-2697] Minor changes about hbase index config. (#3927) --- .../java/org/apache/hudi/config/HoodieHBaseIndexConfig.java | 6 +++--- .../main/java/org/apache/hudi/config/HoodieWriteConfig.java | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieHBaseIndexConfig.java b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieHBaseIndexConfig.java index 561460777..3d7e3a794 100644 --- a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieHBaseIndexConfig.java +++ b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieHBaseIndexConfig.java @@ -76,9 +76,9 @@ public class HoodieHBaseIndexConfig extends HoodieConfig { .withDocumentation("Property to set which implementation of HBase QPS resource allocator to be used, which" + "controls the batching rate dynamically."); - public static final ConfigProperty PUT_BATCH_SIZE_AUTO_COMPUTE = ConfigProperty + public static final ConfigProperty PUT_BATCH_SIZE_AUTO_COMPUTE = ConfigProperty .key("hoodie.index.hbase.put.batch.size.autocompute") - .defaultValue("false") + .defaultValue(false) .withDocumentation("Property to set to enable auto computation of put batch size"); public static final ConfigProperty QPS_FRACTION = ConfigProperty @@ -206,7 +206,7 @@ public class HoodieHBaseIndexConfig extends HoodieConfig { * @deprecated Use {@link #PUT_BATCH_SIZE_AUTO_COMPUTE} and its methods instead */ @Deprecated - public static final String DEFAULT_HBASE_PUT_BATCH_SIZE_AUTO_COMPUTE = PUT_BATCH_SIZE_AUTO_COMPUTE.defaultValue(); + public static final Boolean DEFAULT_HBASE_PUT_BATCH_SIZE_AUTO_COMPUTE = PUT_BATCH_SIZE_AUTO_COMPUTE.defaultValue(); /** * @deprecated Use {@link #MAX_QPS_FRACTION} and its methods instead */ diff --git a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java index e167b12c8..eb3df3842 100644 --- a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java +++ b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java @@ -1295,8 +1295,8 @@ public class HoodieWriteConfig extends HoodieConfig { return getInt(HoodieHBaseIndexConfig.PUT_BATCH_SIZE); } - public Boolean getHbaseIndexPutBatchSizeAutoCompute() { - return getBoolean(HoodieHBaseIndexConfig.PUT_BATCH_SIZE_AUTO_COMPUTE); + public boolean getHbaseIndexPutBatchSizeAutoCompute() { + return getBooleanOrDefault(HoodieHBaseIndexConfig.PUT_BATCH_SIZE_AUTO_COMPUTE); } public String getHBaseQPSResourceAllocatorClass() { @@ -1357,7 +1357,7 @@ public class HoodieWriteConfig extends HoodieConfig { } public boolean getHbaseIndexUpdatePartitionPath() { - return getBoolean(HoodieHBaseIndexConfig.UPDATE_PARTITION_PATH_ENABLE); + return getBooleanOrDefault(HoodieHBaseIndexConfig.UPDATE_PARTITION_PATH_ENABLE); } public int getBloomIndexParallelism() {