From 1713f686f86e8c2f0a908c313cca9b595c6aed33 Mon Sep 17 00:00:00 2001 From: Raymond Xu <2701446+xushiyan@users.noreply.github.com> Date: Thu, 26 Mar 2020 19:21:38 -0700 Subject: [PATCH] [MINOR] Add error message when check arguments (#1451) --- .../java/org/apache/hudi/config/HoodieCompactionConfig.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hudi-client/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java b/hudi-client/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java index 074ea7888..a7275c8f3 100644 --- a/hudi-client/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java +++ b/hudi-client/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java @@ -288,7 +288,11 @@ public class HoodieCompactionConfig extends DefaultHoodieConfig { int maxInstantsToKeep = Integer.parseInt(props.getProperty(HoodieCompactionConfig.MAX_COMMITS_TO_KEEP_PROP)); int cleanerCommitsRetained = Integer.parseInt(props.getProperty(HoodieCompactionConfig.CLEANER_COMMITS_RETAINED_PROP)); - ValidationUtils.checkArgument(maxInstantsToKeep > minInstantsToKeep); + ValidationUtils.checkArgument(maxInstantsToKeep > minInstantsToKeep, + String.format( + "Increase %s=%d to be greater than %s=%d.", + HoodieCompactionConfig.MAX_COMMITS_TO_KEEP_PROP, maxInstantsToKeep, + HoodieCompactionConfig.MIN_COMMITS_TO_KEEP_PROP, minInstantsToKeep)); ValidationUtils.checkArgument(minInstantsToKeep > cleanerCommitsRetained, String.format( "Increase %s=%d to be greater than %s=%d. Otherwise, there is risk of incremental pull "