From 257a6a74569cdb500b06c53b92d05f6f5833aa31 Mon Sep 17 00:00:00 2001
From: xuzifu666 <1206332514@qq.com>
Date: Sat, 27 Nov 2021 07:11:01 +0800
Subject: [PATCH] [HUDI-2856] Bit cask disk map delete modified (#4116)

* modified BitCaskDiskMap_close_function

* change iterators location to finally

* Update BitCaskDiskMap.java
---
 .../apache/hudi/common/util/collection/BitCaskDiskMap.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
index 289901df8..7644afa4b 100644
--- a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
+++ b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
@@ -281,12 +281,12 @@ public final class BitCaskDiskMap<T extends Serializable, R extends Serializable
           }
         }
       }
-      writeOnlyFile.delete();
-      this.iterators.forEach(ClosableIterator::close);
     } catch (Exception e) {
       // delete the file for any sort of exception
-      writeOnlyFile.delete();
+      LOG.error("BitCaskDisMap close error ", e);
     } finally {
+      this.iterators.forEach(ClosableIterator::close);
+      writeOnlyFile.delete();
       super.close();
     }
   }