lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-379] Refactor the codes based on new JavadocStyle code style rule (#1079)

Browse Source
This commit is contained in:
lamber-ken
2019-12-06 12:59:28 +08:00
committed by leesf
parent c06d89b648
commit 2745b7552f
137 changed files with 434 additions and 433 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
hudi-client/src/test/java/org/apache/hudi/TestAsyncCompaction.java
View File

@@ -65,7 +65,7 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
/**
* Test Cases for Async Compaction and Ingestion interaction
* Test Cases for Async Compaction and Ingestion interaction.
*/
public class TestAsyncCompaction extends TestHoodieClientBase {
@@ -400,7 +400,7 @@ public class TestAsyncCompaction extends TestHoodieClientBase {
}
/**
* HELPER METHODS FOR TESTING
* HELPER METHODS FOR TESTING.
**/
private void validateDeltaCommit(String latestDeltaCommit,

46
hudi-client/src/test/java/org/apache/hudi/TestCleaner.java
View File

@@ -87,7 +87,7 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
/**
* Test Cleaning related logic
* Test Cleaning related logic.
*/
public class TestCleaner extends TestHoodieClientBase {
@@ -95,7 +95,7 @@ public class TestCleaner extends TestHoodieClientBase {
private static Logger logger = LogManager.getLogger(TestHoodieClientBase.class);
/**
* Helper method to do first batch of insert for clean by versions/commits tests
* Helper method to do first batch of insert for clean by versions/commits tests.
*
* @param cfg Hoodie Write Config
* @param client Hoodie Client
@@ -140,7 +140,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using insert/upsert API
* Test Clean-By-Versions using insert/upsert API.
*/
@Test
public void testInsertAndCleanByVersions() throws Exception {
@@ -148,7 +148,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using prepped versions of insert/upsert API
* Test Clean-By-Versions using prepped versions of insert/upsert API.
*/
@Test
public void testInsertPreppedAndCleanByVersions() throws Exception {
@@ -157,7 +157,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using bulk-insert/upsert API
* Test Clean-By-Versions using bulk-insert/upsert API.
*/
@Test
public void testBulkInsertAndCleanByVersions() throws Exception {
@@ -165,7 +165,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using prepped versions of bulk-insert/upsert API
* Test Clean-By-Versions using prepped versions of bulk-insert/upsert API.
*/
@Test
public void testBulkInsertPreppedAndCleanByVersions() throws Exception {
@@ -175,7 +175,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Helper for Cleaning by versions logic from HoodieWriteClient API perspective
* Test Helper for Cleaning by versions logic from HoodieWriteClient API perspective.
*
* @param insertFn Insert API to be tested
* @param upsertFn Upsert API to be tested
@@ -301,7 +301,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using insert/upsert API
* Test Clean-By-Versions using insert/upsert API.
*/
@Test
public void testInsertAndCleanByCommits() throws Exception {
@@ -309,7 +309,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using prepped version of insert/upsert API
* Test Clean-By-Versions using prepped version of insert/upsert API.
*/
@Test
public void testInsertPreppedAndCleanByCommits() throws Exception {
@@ -317,7 +317,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using prepped versions of bulk-insert/upsert API
* Test Clean-By-Versions using prepped versions of bulk-insert/upsert API.
*/
@Test
public void testBulkInsertPreppedAndCleanByCommits() throws Exception {
@@ -327,7 +327,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Clean-By-Versions using bulk-insert/upsert API
* Test Clean-By-Versions using bulk-insert/upsert API.
*/
@Test
public void testBulkInsertAndCleanByCommits() throws Exception {
@@ -335,7 +335,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Helper for Cleaning by versions logic from HoodieWriteClient API perspective
* Test Helper for Cleaning by versions logic from HoodieWriteClient API perspective.
*
* @param insertFn Insert API to be tested
* @param upsertFn Upsert API to be tested
@@ -407,7 +407,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Helper to run cleaner and collect Clean Stats
* Helper to run cleaner and collect Clean Stats.
*
* @param config HoodieWriteConfig
*/
@@ -416,7 +416,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Helper to run cleaner and collect Clean Stats
* Helper to run cleaner and collect Clean Stats.
*
* @param config HoodieWriteConfig
*/
@@ -463,7 +463,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test HoodieTable.clean() Cleaning by versions logic
* Test HoodieTable.clean() Cleaning by versions logic.
*/
@Test
public void testKeepLatestFileVersions() throws IOException {
@@ -555,7 +555,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test HoodieTable.clean() Cleaning by versions logic for MOR table with Log files
* Test HoodieTable.clean() Cleaning by versions logic for MOR table with Log files.
*/
@Test
public void testKeepLatestFileVersionsMOR() throws IOException {
@@ -701,7 +701,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test HoodieTable.clean() Cleaning by commit logic for MOR table with Log files
* Test HoodieTable.clean() Cleaning by commit logic for MOR table with Log files.
*/
@Test
public void testKeepLatestCommits() throws IOException {
@@ -718,7 +718,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test HoodieTable.clean() Cleaning by commit logic for MOR table with Log files
* Test HoodieTable.clean() Cleaning by commit logic for MOR table with Log files.
*/
@Test
public void testKeepLatestCommitsIncrMode() throws IOException {
@@ -936,7 +936,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Test Keep Latest Commits when there are pending compactions
* Test Keep Latest Commits when there are pending compactions.
*/
@Test
public void testKeepLatestCommitsWithPendingCompactions() throws IOException {
@@ -967,7 +967,7 @@ public class TestCleaner extends TestHoodieClientBase {
/**
* Test Keep Latest Versions when there are pending compactions
* Test Keep Latest Versions when there are pending compactions.
*/
@Test
public void testKeepLatestVersionsWithPendingCompactionsAndFailureRetry() throws IOException {
@@ -993,7 +993,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Common test method for validating pending compactions
* Common test method for validating pending compactions.
*
* @param config Hoodie Write Config
* @param expNumFilesDeleted Number of files deleted
@@ -1111,7 +1111,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/**
* Utility method to create temporary data files
* Utility method to create temporary data files.
*
* @param commitTime Commit Timestamp
* @param numFiles Number for files to be generated
@@ -1127,7 +1127,7 @@ public class TestCleaner extends TestHoodieClientBase {
}
/***
* Helper method to return temporary files count
* Helper method to return temporary files count.
*
* @return Number of temporary files found
* @throws IOException in case of error

8
hudi-client/src/test/java/org/apache/hudi/TestClientRollback.java
View File

@@ -47,12 +47,12 @@ import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
/**
* Test Cases for rollback of snapshots and commits
* Test Cases for rollback of snapshots and commits.
*/
public class TestClientRollback extends TestHoodieClientBase {
/**
* Test case for rollback-savepoint interaction
* Test case for rollback-savepoint interaction.
*/
@Test
public void testSavepointAndRollback() throws Exception {
@@ -165,7 +165,7 @@ public class TestClientRollback extends TestHoodieClientBase {
}
/**
* Test Cases for effects of rollbacking completed/inflight commits
* Test Cases for effects of rollbacking completed/inflight commits.
*/
@Test
public void testRollbackCommit() throws Exception {
@@ -255,7 +255,7 @@ public class TestClientRollback extends TestHoodieClientBase {
}
/**
* Test auto-rollback of commits which are in flight
* Test auto-rollback of commits which are in flight.
*/
@Test
public void testAutoRollbackInflightCommit() throws Exception {

8
hudi-client/src/test/java/org/apache/hudi/TestCompactionAdminClient.java
View File

@@ -163,7 +163,7 @@ public class TestCompactionAdminClient extends TestHoodieClientBase {
}
/**
* Enssure compaction plan is valid
* Enssure compaction plan is valid.
*
* @param compactionInstant Compaction Instant
*/
@@ -206,7 +206,7 @@ public class TestCompactionAdminClient extends TestHoodieClientBase {
}
/**
* Validate Unschedule operations
* Validate Unschedule operations.
*/
private List<Pair<HoodieLogFile, HoodieLogFile>> validateUnSchedulePlan(CompactionAdminClient client,
String ingestionInstant, String compactionInstant, int numEntriesPerInstant, int expNumRenames) throws Exception {
@@ -215,7 +215,7 @@ public class TestCompactionAdminClient extends TestHoodieClientBase {
}
/**
* Validate Unschedule operations
* Validate Unschedule operations.
*/
private List<Pair<HoodieLogFile, HoodieLogFile>> validateUnSchedulePlan(CompactionAdminClient client,
String ingestionInstant, String compactionInstant, int numEntriesPerInstant, int expNumRenames,
@@ -287,7 +287,7 @@ public class TestCompactionAdminClient extends TestHoodieClientBase {
}
/**
* Validate Unschedule operations
* Validate Unschedule operations.
*/
private void validateUnScheduleFileId(CompactionAdminClient client, String ingestionInstant, String compactionInstant,
CompactionOperation op, int expNumRenames) throws Exception {

36
hudi-client/src/test/java/org/apache/hudi/TestHoodieClientBase.java
View File

@@ -66,7 +66,7 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
/**
* Base Class providing setup/cleanup and utility methods for testing Hoodie Client facing tests
* Base Class providing setup/cleanup and utility methods for testing Hoodie Client facing tests.
*/
public class TestHoodieClientBase extends HoodieClientTestHarness {
@@ -104,7 +104,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Get Default HoodieWriteConfig for tests
* Get Default HoodieWriteConfig for tests.
*
* @return Default Hoodie Write Config for tests
*/
@@ -114,7 +114,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
/**
* Get Config builder with default configs set
* Get Config builder with default configs set.
*
* @return Config Builder
*/
@@ -123,7 +123,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Get Config builder with default configs set
* Get Config builder with default configs set.
*
* @return Config Builder
*/
@@ -147,7 +147,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Assert no failures in writing hoodie files
* Assert no failures in writing hoodie files.
*
* @param statuses List of Write Status
*/
@@ -159,7 +159,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Ensure presence of partition meta-data at known depth
* Ensure presence of partition meta-data at known depth.
*
* @param partitionPaths Partition paths to check
* @param fs File System
@@ -175,7 +175,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Ensure records have location field set
* Ensure records have location field set.
*
* @param taggedRecords Tagged Records
* @param commitTime Commit Timestamp
@@ -189,7 +189,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Assert that there is no duplicate key at the partition level
* Assert that there is no duplicate key at the partition level.
*
* @param records List of Hoodie records
*/
@@ -252,7 +252,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Generate wrapper for record generation function for testing Prepped APIs
* Generate wrapper for record generation function for testing Prepped APIs.
*
* @param isPreppedAPI Flag to indicate if this is for testing prepped-version of APIs
* @param writeConfig Hoodie Write Config
@@ -269,7 +269,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Generate wrapper for delete key generation function for testing Prepped APIs
* Generate wrapper for delete key generation function for testing Prepped APIs.
*
* @param isPreppedAPI Flag to indicate if this is for testing prepped-version of APIs
* @param writeConfig Hoodie Write Config
@@ -286,7 +286,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Helper to insert first batch of records and do regular assertions on the state after successful completion
* Helper to insert first batch of records and do regular assertions on the state after successful completion.
*
* @param writeConfig Hoodie Write Config
* @param client Hoodie Write Client
@@ -312,7 +312,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Helper to upsert batch of records and do regular assertions on the state after successful completion
* Helper to upsert batch of records and do regular assertions on the state after successful completion.
*
* @param writeConfig Hoodie Write Config
* @param client Hoodie Write Client
@@ -344,7 +344,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Helper to delete batch of keys and do regular assertions on the state after successful completion
* Helper to delete batch of keys and do regular assertions on the state after successful completion.
*
* @param writeConfig Hoodie Write Config
* @param client Hoodie Write Client
@@ -374,7 +374,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Helper to insert/upsert batch of records and do regular assertions on the state after successful completion
* Helper to insert/upsert batch of records and do regular assertions on the state after successful completion.
*
* @param client Hoodie Write Client
* @param newCommitTime New Commit Timestamp to be used
@@ -445,7 +445,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Helper to delete batch of hoodie keys and do regular assertions on the state after successful completion
* Helper to delete batch of hoodie keys and do regular assertions on the state after successful completion.
*
* @param client Hoodie Write Client
* @param newCommitTime New Commit Timestamp to be used
@@ -507,7 +507,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Get Cleaner state corresponding to a partition path
* Get Cleaner state corresponding to a partition path.
*
* @param hoodieCleanStatsTwo List of Clean Stats
* @param partitionPath Partition path for filtering
@@ -518,7 +518,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Utility to simulate commit touching files in a partition
* Utility to simulate commit touching files in a partition.
*
* @param files List of file-Ids to be touched
* @param partitionPath Partition
@@ -532,7 +532,7 @@ public class TestHoodieClientBase extends HoodieClientTestHarness {
}
/**
* Helper methods to create new data files in a partition
* Helper methods to create new data files in a partition.
*
* @param partitionPath Partition
* @param commitTime Commit Timestamp

52
hudi-client/src/test/java/org/apache/hudi/TestHoodieClientOnCopyOnWriteStorage.java
View File

@@ -77,7 +77,7 @@ import static org.mockito.Mockito.when;
public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
/**
* Test Auto Commit behavior for HoodieWriteClient insert API
* Test Auto Commit behavior for HoodieWriteClient insert API.
*/
@Test
public void testAutoCommitOnInsert() throws Exception {
@@ -85,7 +85,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Auto Commit behavior for HoodieWriteClient insertPrepped API
* Test Auto Commit behavior for HoodieWriteClient insertPrepped API.
*/
@Test
public void testAutoCommitOnInsertPrepped() throws Exception {
@@ -93,7 +93,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Auto Commit behavior for HoodieWriteClient upsert API
* Test Auto Commit behavior for HoodieWriteClient upsert API.
*/
@Test
public void testAutoCommitOnUpsert() throws Exception {
@@ -101,7 +101,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Auto Commit behavior for HoodieWriteClient upsert Prepped API
* Test Auto Commit behavior for HoodieWriteClient upsert Prepped API.
*/
@Test
public void testAutoCommitOnUpsertPrepped() throws Exception {
@@ -109,7 +109,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Auto Commit behavior for HoodieWriteClient bulk-insert API
* Test Auto Commit behavior for HoodieWriteClient bulk-insert API.
*/
@Test
public void testAutoCommitOnBulkInsert() throws Exception {
@@ -117,7 +117,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Auto Commit behavior for HoodieWriteClient bulk-insert prepped API
* Test Auto Commit behavior for HoodieWriteClient bulk-insert prepped API.
*/
@Test
public void testAutoCommitOnBulkInsertPrepped() throws Exception {
@@ -126,7 +126,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test auto-commit by applying write function
* Test auto-commit by applying write function.
*
* @param writeFn One of HoodieWriteClient Write API
* @throws Exception in case of failure
@@ -152,7 +152,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test De-duplication behavior for HoodieWriteClient insert API
* Test De-duplication behavior for HoodieWriteClient insert API.
*/
@Test
public void testDeduplicationOnInsert() throws Exception {
@@ -160,7 +160,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test De-duplication behavior for HoodieWriteClient bulk-insert API
* Test De-duplication behavior for HoodieWriteClient bulk-insert API.
*/
@Test
public void testDeduplicationOnBulkInsert() throws Exception {
@@ -168,7 +168,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test De-duplication behavior for HoodieWriteClient upsert API
* Test De-duplication behavior for HoodieWriteClient upsert API.
*/
@Test
public void testDeduplicationOnUpsert() throws Exception {
@@ -176,7 +176,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Deduplication Logic for write function
* Test Deduplication Logic for write function.
*
* @param writeFn One of HoddieWriteClient non-prepped write APIs
* @throws Exception in case of failure
@@ -224,7 +224,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Build a test Hoodie WriteClient with dummy index to configure isGlobal flag
* Build a test Hoodie WriteClient with dummy index to configure isGlobal flag.
*
* @param isGlobal Flag to control HoodieIndex.isGlobal
* @return Hoodie Write Client
@@ -237,7 +237,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test Upsert API
* Test Upsert API.
*/
@Test
public void testUpserts() throws Exception {
@@ -245,7 +245,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test UpsertPrepped API
* Test UpsertPrepped API.
*/
@Test
public void testUpsertsPrepped() throws Exception {
@@ -253,7 +253,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test one of HoodieWriteClient upsert(Prepped) APIs
* Test one of HoodieWriteClient upsert(Prepped) APIs.
*
* @param hoodieWriteConfig Write Config
* @param writeFn One of Hoodie Write Function API
@@ -291,7 +291,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Tesst deletion of records
* Tesst deletion of records.
*/
@Test
public void testDeletes() throws Exception {
@@ -318,7 +318,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
-1, recordGenFunction, HoodieWriteClient::upsert, true, 200, 200, 1);
/**
* Write 2 (deletes+writes)
* Write 2 (deletes+writes).
*/
String prevCommitTime = newCommitTime;
newCommitTime = "004";
@@ -336,7 +336,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test scenario of new file-group getting added during upsert()
* Test scenario of new file-group getting added during upsert().
*/
@Test
public void testSmallInsertHandlingForUpserts() throws Exception {
@@ -448,7 +448,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test scenario of new file-group getting added during insert()
* Test scenario of new file-group getting added during insert().
*/
@Test
public void testSmallInsertHandlingForInserts() throws Exception {
@@ -530,7 +530,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test delete with delete api
* Test delete with delete api.
*/
@Test
public void testDeletesWithDeleteApi() throws Exception {
@@ -659,7 +659,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test delete with delete api
* Test delete with delete api.
*/
@Test
public void testDeletesWithoutInserts() throws Exception {
@@ -688,7 +688,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test to ensure commit metadata points to valid files
* Test to ensure commit metadata points to valid files.
*/
@Test
public void testCommitWritesRelativePaths() throws Exception {
@@ -735,7 +735,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Test to ensure commit metadata points to valid files
* Test to ensure commit metadata points to valid files.
*/
@Test
public void testRollingStatsInMetadata() throws Exception {
@@ -810,7 +810,7 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Tests behavior of committing only when consistency is verified
* Tests behavior of committing only when consistency is verified.
*/
@Test
public void testConsistencyCheckDuringFinalize() throws Exception {
@@ -879,14 +879,14 @@ public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
}
/**
* Build Hoodie Write Config for small data file sizes
* Build Hoodie Write Config for small data file sizes.
*/
private HoodieWriteConfig getSmallInsertWriteConfig(int insertSplitSize) {
return getSmallInsertWriteConfig(insertSplitSize, false);
}
/**
* Build Hoodie Write Config for small data file sizes
* Build Hoodie Write Config for small data file sizes.
*/
private HoodieWriteConfig getSmallInsertWriteConfig(int insertSplitSize, boolean useNullSchema) {
HoodieWriteConfig.Builder builder = getConfigBuilder(useNullSchema ? NULL_SCHEMA : TRIP_EXAMPLE_SCHEMA);

20
hudi-client/src/test/java/org/apache/hudi/TestHoodieReadClient.java
View File

@@ -40,7 +40,7 @@ import static org.junit.Assert.assertTrue;
public class TestHoodieReadClient extends TestHoodieClientBase {
/**
* Test ReadFilter API after writing new records using HoodieWriteClient.insert
* Test ReadFilter API after writing new records using HoodieWriteClient.insert.
*/
@Test
public void testReadFilterExistAfterInsert() throws Exception {
@@ -48,7 +48,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test ReadFilter API after writing new records using HoodieWriteClient.insertPrepped
* Test ReadFilter API after writing new records using HoodieWriteClient.insertPrepped.
*/
@Test
public void testReadFilterExistAfterInsertPrepped() throws Exception {
@@ -56,7 +56,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test ReadFilter API after writing new records using HoodieWriteClient.bulkInsert
* Test ReadFilter API after writing new records using HoodieWriteClient.bulkInsert.
*/
@Test
public void testReadFilterExistAfterBulkInsert() throws Exception {
@@ -64,7 +64,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test ReadFilter API after writing new records using HoodieWriteClient.bulkInsertPrepped
* Test ReadFilter API after writing new records using HoodieWriteClient.bulkInsertPrepped.
*/
@Test
public void testReadFilterExistAfterBulkInsertPrepped() throws Exception {
@@ -76,7 +76,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
/**
* Helper to write new records using one of HoodieWriteClient's write API and use ReadClient to test filterExists()
* API works correctly
* API works correctly.
*
* @param config Hoodie Write Config
* @param writeFn Write Function for writing records
@@ -111,7 +111,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test tagLocation API after insert()
* Test tagLocation API after insert().
*/
@Test
public void testTagLocationAfterInsert() throws Exception {
@@ -119,7 +119,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test tagLocation API after insertPrepped()
* Test tagLocation API after insertPrepped().
*/
@Test
public void testTagLocationAfterInsertPrepped() throws Exception {
@@ -128,7 +128,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test tagLocation API after bulk-insert()
* Test tagLocation API after bulk-insert().
*/
@Test
public void testTagLocationAfterBulkInsert() throws Exception {
@@ -137,7 +137,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Test tagLocation API after bulkInsertPrepped()
* Test tagLocation API after bulkInsertPrepped().
*/
@Test
public void testTagLocationAfterBulkInsertPrepped() throws Exception {
@@ -148,7 +148,7 @@ public class TestHoodieReadClient extends TestHoodieClientBase {
}
/**
* Helper method to test tagLocation after using different HoodieWriteClient write APIS
* Helper method to test tagLocation after using different HoodieWriteClient write APIS.
*
* @param hoodieWriteConfig Write Config
* @param insertFn Hoodie Write Client first Insert API

2
hudi-client/src/test/java/org/apache/hudi/common/HoodieClientTestUtils.java
View File

@@ -192,7 +192,7 @@ public class HoodieClientTestUtils {
}
/**
* Reads the paths under the a hoodie dataset out as a DataFrame
* Reads the paths under the a hoodie dataset out as a DataFrame.
*/
public static Dataset<Row> read(JavaSparkContext jsc, String basePath, SQLContext sqlContext, FileSystem fs,
String... paths) {

2
hudi-client/src/test/java/org/apache/hudi/common/HoodieMergeOnReadTestUtils.java
View File

@@ -41,7 +41,7 @@ import java.util.List;
import java.util.stream.Collectors;
/**
* Utility methods to aid in testing MergeOnRead (workaround for HoodieReadClient for MOR)
* Utility methods to aid in testing MergeOnRead (workaround for HoodieReadClient for MOR).
*/
public class HoodieMergeOnReadTestUtils {

2
hudi-client/src/test/java/org/apache/hudi/func/TestBoundedInMemoryQueue.java
View File

@@ -110,7 +110,7 @@ public class TestBoundedInMemoryQueue extends HoodieClientTestHarness {
}
/**
* Test to ensure that we are reading all records from queue iterator when we have multiple producers
* Test to ensure that we are reading all records from queue iterator when we have multiple producers.
*/
@SuppressWarnings("unchecked")
@Test(timeout = 60000)

8
hudi-client/src/test/java/org/apache/hudi/index/bloom/TestKeyRangeLookupTree.java
View File

@@ -31,7 +31,7 @@ import static junit.framework.TestCase.assertEquals;
import static junit.framework.TestCase.assertTrue;
/**
* Tests {@link KeyRangeLookupTree}
* Tests {@link KeyRangeLookupTree}.
*/
public class TestKeyRangeLookupTree {
@@ -59,7 +59,7 @@ public class TestKeyRangeLookupTree {
}
/**
* Tests for many entries in the tree with same start value and different end values
* Tests for many entries in the tree with same start value and different end values.
*/
@Test
public void testFileGroupLookUpManyEntriesWithSameStartValue() {
@@ -78,7 +78,7 @@ public class TestKeyRangeLookupTree {
}
/**
* Tests for many duplicte entries in the tree
* Tests for many duplicte entries in the tree.
*/
@Test
public void testFileGroupLookUpManyDulicateEntries() {
@@ -158,7 +158,7 @@ public class TestKeyRangeLookupTree {
}
/**
* Updates the expected matches for a given {@link KeyRangeNode}
* Updates the expected matches for a given {@link KeyRangeNode}.
*
* @param toInsert the {@link KeyRangeNode} to be inserted
*/

4
hudi-client/src/test/java/org/apache/hudi/io/TestHoodieMergeHandle.java
View File

@@ -318,7 +318,7 @@ public class TestHoodieMergeHandle extends HoodieClientTestHarness {
}
/**
* Assert no failures in writing hoodie files
* Assert no failures in writing hoodie files.
*
* @param statuses List of Write Status
*/
@@ -340,7 +340,7 @@ public class TestHoodieMergeHandle extends HoodieClientTestHarness {
}
/**
* Overridden so that we can capture and inspect all success records
* Overridden so that we can capture and inspect all success records.
*/
public static class TestWriteStatus extends WriteStatus {

4
hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
View File

@@ -1019,7 +1019,7 @@ public class TestMergeOnReadTable extends HoodieClientTestHarness {
}
/**
* Test to ensure rolling stats are correctly written to metadata file
* Test to ensure rolling stats are correctly written to metadata file.
*/
@Test
public void testRollingStatsInMetadata() throws Exception {
@@ -1118,7 +1118,7 @@ public class TestMergeOnReadTable extends HoodieClientTestHarness {
}
/**
* Test to ensure rolling stats are correctly written to the metadata file, identifies small files and corrects them
* Test to ensure rolling stats are correctly written to the metadata file, identifies small files and corrects them.
*/
@Test
public void testRollingStatsWithSmallFileHandling() throws Exception {