From 28ccf8c5216eaedf16b16b0220f03311fcba6787 Mon Sep 17 00:00:00 2001 From: lamber-ken Date: Sun, 5 Jan 2020 15:53:47 +0800 Subject: [PATCH] [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller (#1167) --- .../hudi/utilities/HiveIncrementalPuller.java | 2 +- .../utilities/TestHiveIncrementalPuller.java | 27 +++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java index 963bc7d10..f7d8181ac 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java @@ -112,7 +112,7 @@ public class HiveIncrementalPuller { this.config = config; validateConfig(config); String templateContent = - FileIOUtils.readAsUTFString(this.getClass().getResourceAsStream("IncrementalPull.sqltemplate")); + FileIOUtils.readAsUTFString(this.getClass().getResourceAsStream("/IncrementalPull.sqltemplate")); incrementalPullSQLtemplate = new ST(templateContent); } diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java new file mode 100644 index 000000000..74a75878c --- /dev/null +++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java @@ -0,0 +1,27 @@ +package org.apache.hudi.utilities; + +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestHiveIncrementalPuller { + + private HiveIncrementalPuller.Config config; + + @Before + public void setup() { + config = new HiveIncrementalPuller.Config(); + } + + @Test + public void testInitHiveIncrementalPuller() { + + try { + new HiveIncrementalPuller(config); + } catch (Exception e) { + Assert.fail("Unexpected exception while initing HiveIncrementalPuller, msg: " + e.getMessage()); + } + + } + +}