1
0

[HUDI-902] Avoid exception when getSchemaProvider (#1584)

* When no new input data, don't throw exception for null SchemaProvider
* Return the newly added NullSchemaProvider instead
This commit is contained in:
Raymond Xu
2020-05-15 21:33:02 -07:00
committed by GitHub
parent 25e0b75b3d
commit 2ada2ef50f
2 changed files with 59 additions and 2 deletions

View File

@@ -0,0 +1,37 @@
package org.apache.hudi.utilities.sources;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.exception.HoodieException;
import org.apache.hudi.utilities.schema.RowBasedSchemaProvider;
import org.apache.hudi.utilities.schema.SchemaProvider;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class TestInputBatch {
@Test
public void getSchemaProviderShouldThrowException() {
final InputBatch<String> inputBatch = new InputBatch<>(Option.of("foo"), null, null);
Throwable t = assertThrows(HoodieException.class, inputBatch::getSchemaProvider);
assertEquals("Please provide a valid schema provider class!", t.getMessage());
}
@Test
public void getSchemaProviderShouldReturnNullSchemaProvider() {
final InputBatch<String> inputBatch = new InputBatch<>(Option.empty(), null, null);
SchemaProvider schemaProvider = inputBatch.getSchemaProvider();
assertTrue(schemaProvider instanceof InputBatch.NullSchemaProvider);
}
@Test
public void getSchemaProviderShouldReturnGivenSchemaProvider() {
SchemaProvider schemaProvider = new RowBasedSchemaProvider(null);
final InputBatch<String> inputBatch = new InputBatch<>(Option.of("foo"), null, schemaProvider);
assertSame(schemaProvider, inputBatch.getSchemaProvider());
}
}