From 335e80ea1bdc2327763e55fb9d32e3be75bb07db Mon Sep 17 00:00:00 2001 From: Manoj Govindassamy Date: Mon, 18 Oct 2021 10:07:53 -0700 Subject: [PATCH] [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages (#3811) - InetAddress.getLocalHost() can take up as much as 30+seconds if the network configurations are not done right. This might be due to local hostname missing IPv6 address mapping in /etc/hosts or network configs slowing down any IPv6 name resolutions. If this API is used for logging verbose messages and that too in the hot code path, it can lead to order of magnitude slowness in the overall task completion. --- .../apache/hudi/common/util/collection/BitCaskDiskMap.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java index 7590e9ace..5f78fa3a8 100644 --- a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java +++ b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java @@ -37,7 +37,6 @@ import java.io.IOException; import java.io.InputStream; import java.io.RandomAccessFile; import java.io.Serializable; -import java.net.InetAddress; import java.util.AbstractMap; import java.util.Collection; import java.util.HashSet; @@ -133,9 +132,7 @@ public final class BitCaskDiskMap