Incorporating code review feedback for finalizeWrite for COW #2

hoodie-client/src/main/java/com/uber/hoodie/HoodieWriteClient.java

@@ -848,7 +848,6 @@ public class HoodieWriteClient<T extends HoodieRecordPayload> implements Seriali
         String commitActionType = table.getCommitActionType();
         activeTimeline.createInflight(
             new HoodieInstant(true, commitActionType, commitTime));
-        table.initializeFinalizeWrite();
     }
 
     /**

hoodie-client/src/main/java/com/uber/hoodie/io/HoodieCreateHandle.java

@@ -130,11 +130,7 @@ public class HoodieCreateHandle<T extends HoodieRecordPayload> extends HoodieIOH
       stat.setNumDeletes(recordsDeleted);
       stat.setPrevCommit(HoodieWriteStat.NULL_COMMIT);
       stat.setFileId(status.getFileId());
-      String relativePath = path.toString().replace(new Path(config.getBasePath()) + "/", "");
-      stat.setPath(relativePath);
-      if (tempPath != null) {
-        stat.setTempPath(tempPath.toString().replace(new Path(config.getBasePath()) + "/", ""));
-      }
+      stat.setPaths(new Path(config.getBasePath()), path, tempPath);
       stat.setTotalWriteBytes(FSUtils.getFileSize(fs, getStorageWriterPath()));
       stat.setTotalWriteErrors(status.getFailedRecords().size());
       status.setStat(stat);

hoodie-client/src/main/java/com/uber/hoodie/table/HoodieCopyOnWriteTable.java

@@ -576,24 +576,6 @@ public class HoodieCopyOnWriteTable<T extends HoodieRecordPayload> extends Hoodi
     return stats;
   }
 
-  @Override
-  public void initializeFinalizeWrite() {
-    if (!config.shouldUseTempFolderForCopyOnWrite()) {
-      return;
-    }
-
-    // create temporary folder if needed
-    final FileSystem fs = FSUtils.getFs();
-    final Path temporaryFolder = new Path(config.getBasePath(), HoodieTableMetaClient.TEMPFOLDER_NAME);
-    try {
-      if (!fs.exists(temporaryFolder)) {
-        fs.mkdirs(temporaryFolder);
-      }
-    } catch (IOException e) {
-      throw new HoodieIOException("Failed to create temporary folder: " + temporaryFolder);
-    }
-  }
-
   @Override
   @SuppressWarnings("unchecked")
   public Optional<Integer> finalizeWrite(JavaSparkContext jsc, List writeStatuses) {

hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java

@@ -250,11 +250,6 @@ public class HoodieMergeOnReadTable<T extends HoodieRecordPayload> extends
     return allRollbackStats;
   }
 
-  @Override
-  public void initializeFinalizeWrite() {
-    // do nothing for MOR tables
-  }
-
   @Override
   public Optional<Integer> finalizeWrite(JavaSparkContext jsc, List writeStatuses) {
     // do nothing for MOR tables

hoodie-client/src/main/java/com/uber/hoodie/table/HoodieTable.java

@@ -273,11 +273,6 @@ public abstract class HoodieTable<T extends HoodieRecordPayload> implements Seri
   public abstract List<HoodieRollbackStat> rollback(JavaSparkContext jsc, List<String> commits)
       throws IOException;
 
-  /**
-   * Initialize resources needed for finalize write.
-   */
-  public abstract void initializeFinalizeWrite();
-
   /**
    * Finalize the written data files
    *