From 3d5e9fee7f42d45f737e170a1937bdf676df9c60 Mon Sep 17 00:00:00 2001 From: leesf Date: Sat, 28 Nov 2020 21:47:05 +0800 Subject: [PATCH] [MINOR] refactor code in HoodieMergeHandle (#2272) --- .../main/java/org/apache/hudi/io/HoodieMergeHandle.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java index be324a3c5..ad03023d7 100644 --- a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java +++ b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java @@ -241,14 +241,11 @@ public class HoodieMergeHandle extends H if (copyOldRecord) { // this should work as it is, since this is an existing record - String errMsg = "Failed to merge old record into new file for key " + key + " from old file " + getOldFilePath() - + " to new file " + newFilePath + " with writerSchema " + writerSchemaWithMetafields.toString(true); try { fileWriter.writeAvro(key, oldRecord); - } catch (ClassCastException e) { - LOG.debug("Old record is " + oldRecord); - throw new HoodieUpsertException(errMsg, e); } catch (IOException | RuntimeException e) { + String errMsg = String.format("Failed to merge old record into new file for key %s from old file %s to new file %s with writerSchema %s", + key, getOldFilePath(), newFilePath, writerSchemaWithMetafields.toString(true)); LOG.debug("Old record is " + oldRecord); throw new HoodieUpsertException(errMsg, e); }