lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-1890] FlinkCreateHandle and FlinkAppendHandle canWrite should always return true (#2933)

Browse Source 
The method #canWrite should always return true because they can already
write based on file size, e.g. the BucketAssigner.
This commit is contained in:
Danny Chan
2021-05-11 09:14:51 +08:00
committed by GitHub
parent aa398f77f1
commit 42ec7e30d7
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/FlinkAppendHandle.java
View File

@@ -75,6 +75,11 @@ public class FlinkAppendHandle<T extends HoodieRecordPayload, I, K, O> extends H
&& hoodieRecord.getCurrentLocation().getInstantTime().equals("U"); && hoodieRecord.getCurrentLocation().getInstantTime().equals("U");
} }
@Override
public boolean canWrite(HoodieRecord record) {
return true;
}
/** /**
* Returns whether there is need to bootstrap this file handle. * Returns whether there is need to bootstrap this file handle.
* E.G. the first time that the handle is created. * E.G. the first time that the handle is created.

6
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/FlinkCreateHandle.java
View File

@@ -21,6 +21,7 @@ package org.apache.hudi.io;
import org.apache.hudi.client.WriteStatus; import org.apache.hudi.client.WriteStatus;
import org.apache.hudi.common.engine.TaskContextSupplier; import org.apache.hudi.common.engine.TaskContextSupplier;
import org.apache.hudi.common.fs.FSUtils; import org.apache.hudi.common.fs.FSUtils;
import org.apache.hudi.common.model.HoodieRecord;
import org.apache.hudi.common.model.HoodieRecordPayload; import org.apache.hudi.common.model.HoodieRecordPayload;
import org.apache.hudi.common.util.HoodieTimer; import org.apache.hudi.common.util.HoodieTimer;
import org.apache.hudi.common.util.collection.Pair; import org.apache.hudi.common.util.collection.Pair;
@@ -123,6 +124,11 @@ public class FlinkCreateHandle<T extends HoodieRecordPayload, I, K, O>
} }
} }
@Override
public boolean canWrite(HoodieRecord record) {
return true;
}
/** /**
* Use the writeToken + "-" + rollNumber as the new writeToken of a mini-batch write. * Use the writeToken + "-" + rollNumber as the new writeToken of a mini-batch write.
*/ */