diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java index ee31d4a60..42ab6ca55 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java @@ -85,7 +85,7 @@ public class HoodieSnapshotExporter { public static class OutputFormatValidator implements IValueValidator { public static final String HUDI = "hudi"; - public static final List FORMATS = CollectionUtils.createImmutableList("json", "parquet", HUDI); + public static final List FORMATS = CollectionUtils.createImmutableList("json", "parquet", "orc", HUDI); @Override public void validate(String name, String value) { @@ -104,7 +104,7 @@ public class HoodieSnapshotExporter { @Parameter(names = {"--target-output-path"}, description = "Base path for the target output files (snapshots)", required = true) public String targetOutputPath; - @Parameter(names = {"--output-format"}, description = "Output format for the exported dataset; accept these values: json|parquet|hudi", required = true, + @Parameter(names = {"--output-format"}, description = "Output format for the exported dataset; accept these values: json|parquet|orc|hudi", required = true, validateValueWith = OutputFormatValidator.class) public String outputFormat; diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java index ae74c1d04..1096c929b 100644 --- a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java +++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java @@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; public class TestHoodieSnapshotExporter { @ParameterizedTest - @ValueSource(strings = {"json", "parquet", "hudi"}) + @ValueSource(strings = {"json", "parquet", "orc", "hudi"}) public void testValidateOutputFormatWithValidFormat(String format) { assertDoesNotThrow(() -> { new OutputFormatValidator().validate(null, format); diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java index aefa49fa9..133205cb8 100644 --- a/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java +++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieSnapshotExporter.java @@ -213,7 +213,7 @@ public class TestHoodieSnapshotExporter extends FunctionalTestHarness { public class TestHoodieSnapshotExporterForNonHudi { @ParameterizedTest - @ValueSource(strings = {"json", "parquet"}) + @ValueSource(strings = {"json", "parquet", "orc"}) public void testExportAsNonHudi(String format) throws IOException { HoodieSnapshotExporter.Config cfg = new Config(); cfg.sourceBasePath = sourcePath;