lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-2934] Optimize RequestHandler code style

Browse Source 
close apache/hudi#4215
This commit is contained in:
fengli
2021-12-04 13:56:25 +08:00
committed by yuzhao.cyz
parent 1d4fb827e7
commit 568181a3e7
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SchemaDifference.java
View File

@@ -28,7 +28,6 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.StringJoiner; import java.util.StringJoiner;
/** /**
* Represents the schema difference between the storage schema and hive table schema. * Represents the schema difference between the storage schema and hive table schema.
*/ */

5
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
View File

@@ -39,8 +39,9 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import static org.apache.hudi.hive.util.HiveSchemaUtil.HIVE_ESCAPE_CHARACTER; import static org.apache.hudi.hive.util.HiveSchemaUtil.HIVE_ESCAPE_CHARACTER;
/*
This class adds functionality for all query based DDLExecutors. The classes extending it only have to provide runSQL(sql) functions. /**
* This class adds functionality for all query based DDLExecutors. The classes extending it only have to provide runSQL(sql) functions.
*/ */
public abstract class QueryBasedDDLExecutor implements DDLExecutor { public abstract class QueryBasedDDLExecutor implements DDLExecutor {
private static final Logger LOG = LogManager.getLogger(QueryBasedDDLExecutor.class); private static final Logger LOG = LogManager.getLogger(QueryBasedDDLExecutor.class);

2
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
View File

@@ -500,6 +500,7 @@ public class RequestHandler {
if (refreshCheck) { if (refreshCheck) {
long beginFinalCheck = System.currentTimeMillis(); long beginFinalCheck = System.currentTimeMillis();
if (isLocalViewBehind(context)) {
String errMsg = String errMsg =
"Last known instant from client was " "Last known instant from client was "
+ context.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS, + context.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS,
@@ -507,7 +508,6 @@ public class RequestHandler {
+ " but server has the following timeline " + " but server has the following timeline "
+ viewManager.getFileSystemView(context.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM)) + viewManager.getFileSystemView(context.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM))
.getTimeline().getInstants().collect(Collectors.toList()); .getTimeline().getInstants().collect(Collectors.toList());
if (isLocalViewBehind(context)) {
throw new BadRequestResponse(errMsg); throw new BadRequestResponse(errMsg);
} }
long endFinalCheck = System.currentTimeMillis(); long endFinalCheck = System.currentTimeMillis();