diff --git a/hudi-client/src/main/java/org/apache/hudi/table/action/commit/InsertBucket.java b/hudi-client/src/main/java/org/apache/hudi/table/action/commit/InsertBucket.java index d5dcec857..2cedbe865 100644 --- a/hudi-client/src/main/java/org/apache/hudi/table/action/commit/InsertBucket.java +++ b/hudi-client/src/main/java/org/apache/hudi/table/action/commit/InsertBucket.java @@ -32,10 +32,10 @@ public class InsertBucket implements Serializable { @Override public String toString() { - final StringBuilder sb = new StringBuilder("WorkloadStat {"); + final StringBuilder sb = new StringBuilder("InsertBucket {"); sb.append("bucketNumber=").append(bucketNumber).append(", "); sb.append("weight=").append(weight); sb.append('}'); return sb.toString(); } -} \ No newline at end of file +} diff --git a/hudi-client/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java b/hudi-client/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java index 7c42e6723..f64483abc 100644 --- a/hudi-client/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java +++ b/hudi-client/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java @@ -28,6 +28,7 @@ import org.apache.hudi.common.table.log.block.HoodieCommandBlock; import org.apache.hudi.common.table.log.block.HoodieCommandBlock.HoodieCommandBlockTypeEnum; import org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType; import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.Option; import org.apache.hudi.common.util.ValidationUtils; import org.apache.hudi.config.HoodieWriteConfig; import org.apache.hudi.exception.HoodieRollbackException; @@ -151,25 +152,12 @@ public class RollbackHelper implements Serializable { final List successDeleteFiles = new ArrayList<>(); final List failedDeleteFiles = new ArrayList<>(); final Map commandBlocksCount = new HashMap<>(); - - if (stat1.getSuccessDeleteFiles() != null) { - successDeleteFiles.addAll(stat1.getSuccessDeleteFiles()); - } - if (stat2.getSuccessDeleteFiles() != null) { - successDeleteFiles.addAll(stat2.getSuccessDeleteFiles()); - } - if (stat1.getFailedDeleteFiles() != null) { - failedDeleteFiles.addAll(stat1.getFailedDeleteFiles()); - } - if (stat2.getFailedDeleteFiles() != null) { - failedDeleteFiles.addAll(stat2.getFailedDeleteFiles()); - } - if (stat1.getCommandBlocksCount() != null) { - commandBlocksCount.putAll(stat1.getCommandBlocksCount()); - } - if (stat2.getCommandBlocksCount() != null) { - commandBlocksCount.putAll(stat2.getCommandBlocksCount()); - } + Option.ofNullable(stat1.getSuccessDeleteFiles()).ifPresent(successDeleteFiles::addAll); + Option.ofNullable(stat2.getSuccessDeleteFiles()).ifPresent(successDeleteFiles::addAll); + Option.ofNullable(stat1.getFailedDeleteFiles()).ifPresent(failedDeleteFiles::addAll); + Option.ofNullable(stat2.getFailedDeleteFiles()).ifPresent(failedDeleteFiles::addAll); + Option.ofNullable(stat1.getCommandBlocksCount()).ifPresent(commandBlocksCount::putAll); + Option.ofNullable(stat2.getCommandBlocksCount()).ifPresent(commandBlocksCount::putAll); return new HoodieRollbackStat(stat1.getPartitionPath(), successDeleteFiles, failedDeleteFiles, commandBlocksCount); } diff --git a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieTimeline.java b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieTimeline.java old mode 100755 new mode 100644