lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[MINOR] typo fix in BaseTableMetadata wrt spurious deletes handling (#4673)

Browse Source 
Co-authored-by: yuezhang <yuezhang@freewheel.tv>
This commit is contained in:
YueZhang
2022-01-24 20:09:54 +08:00
committed by GitHub
parent e00a9042e9
commit 7bd389fb47
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
View File

@@ -535,7 +535,7 @@ public abstract class HoodieBackedTableMetadataWriter implements HoodieTableMeta
* All FileGroups for a given metadata partition has a fixed prefix as per the {@link MetadataPartitionType#getFileIdPrefix()}. * All FileGroups for a given metadata partition has a fixed prefix as per the {@link MetadataPartitionType#getFileIdPrefix()}.
* Each file group is suffixed with 4 digits with increments of 1 starting with 0000. * Each file group is suffixed with 4 digits with increments of 1 starting with 0000.
* *
* Lets say we configure 10 file groups for record level index partittion, and prefix as "record-index-bucket-" * Lets say we configure 10 file groups for record level index partition, and prefix as "record-index-bucket-"
* File groups will be named as : * File groups will be named as :
* record-index-bucket-0000, .... -> ..., record-index-bucket-0009 * record-index-bucket-0000, .... -> ..., record-index-bucket-0009
*/ */

10
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
View File

@@ -231,18 +231,18 @@ public abstract class BaseTableMetadata implements HoodieTableMetadata {
} }
/** /**
* May be handle spurious deletes. Depending on config, throw an exception or log a warn msg. * Maybe handle spurious deletes. Depending on config, throw an exception or log a warn msg.
* @param hoodieRecord instance of {@link HoodieRecord} of interest. * @param hoodieRecord instance of {@link HoodieRecord} of interest.
* @param partitionName partition name of interest. * @param partitionName partition name of interest.
*/ */
private void mayBeHandleSpuriousDeletes(Option<HoodieRecord<HoodieMetadataPayload>> hoodieRecord, String partitionName) { private void mayBeHandleSpuriousDeletes(Option<HoodieRecord<HoodieMetadataPayload>> hoodieRecord, String partitionName) {
if (!hoodieRecord.get().getData().getDeletions().isEmpty()) { if (!hoodieRecord.get().getData().getDeletions().isEmpty()) {
if (!metadataConfig.ignoreSpuriousDeletes()) { if (metadataConfig.ignoreSpuriousDeletes()) {
LOG.warn("Metadata record for " + partitionName + " encountered some files to be deleted which was not added before. "
+ "Ignoring the spurious deletes as the `" + HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + "` config is set to true");
} else {
throw new HoodieMetadataException("Metadata record for " + partitionName + " is inconsistent: " throw new HoodieMetadataException("Metadata record for " + partitionName + " is inconsistent: "
+ hoodieRecord.get().getData()); + hoodieRecord.get().getData());
} else {
LOG.warn("Metadata record for " + partitionName + " encountered some files to be deleted which was not added before. "
+ "Ignoring the spurious deletes as the `" + HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + "` config is set to false");
} }
} }
} }