From 8b00791ef47f708f54ffbfb5789ed65f958740b3 Mon Sep 17 00:00:00 2001 From: Zhiyuan Zhao <49054376+zhaomin1423@users.noreply.github.com> Date: Sun, 22 Mar 2020 11:12:06 +0800 Subject: [PATCH] [MINOR] cleanup redundant comment and unused variable and fix typo (#1435) --- .../org/apache/hudi/utilities/deltastreamer/DeltaSync.java | 1 - .../hudi/utilities/deltastreamer/HoodieDeltaStreamer.java | 2 +- .../main/java/org/apache/hudi/utilities/sources/Source.java | 3 --- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java index b8524ba30..5a8510fbb 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java @@ -303,7 +303,6 @@ public class DeltaSync implements Serializable { t, HOODIE_RECORD_STRUCT_NAME, HOODIE_RECORD_NAMESPACE).toJavaRDD()); } - // Use Transformed Row's schema if not overridden // Use Transformed Row's schema if not overridden. If target schema is not specified // default to RowBasedSchemaProvider schemaProvider = this.schemaProvider == null || this.schemaProvider.getTargetSchema() == null diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java index bff2b41ae..5bf81c234 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java @@ -124,7 +124,7 @@ public class HoodieDeltaStreamer implements Serializable { throw ex; } finally { deltaSyncService.close(); - LOG.info("Shut down deltastreamer"); + LOG.info("Shut down delta streamer"); } } } diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/Source.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/Source.java index 0760c7399..500691612 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/Source.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/Source.java @@ -22,8 +22,6 @@ import org.apache.hudi.common.util.Option; import org.apache.hudi.common.util.TypedProperties; import org.apache.hudi.utilities.schema.SchemaProvider; -import org.apache.log4j.LogManager; -import org.apache.log4j.Logger; import org.apache.spark.api.java.JavaSparkContext; import org.apache.spark.sql.SparkSession; @@ -33,7 +31,6 @@ import java.io.Serializable; * Represents a source from which we can tail data. Assumes a constructor that takes properties. */ public abstract class Source implements Serializable { - private static final Logger LOG = LogManager.getLogger(Source.class); public enum SourceType { JSON, AVRO, ROW