[MINOR] Refactor hive sync tool to reduce duplicate code (#3276)

* [MINOR] Refactor hive sync tool to reduce duplicate code

hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java

@@ -113,6 +113,18 @@ public class HiveSyncTool extends AbstractSyncTool {
   public void syncHoodieTable() {
     try {
       if (hoodieHiveClient != null) {
+        doSync();
+      }
+    } catch (RuntimeException re) {
+      throw new HoodieException("Got runtime exception when hive syncing " + cfg.tableName, re);
+    } finally {
+      if (hoodieHiveClient != null) {
+        hoodieHiveClient.close();
+      }
+    }
+  }
+
+  protected void doSync() {
     switch (hoodieHiveClient.getTableType()) {
       case COPY_ON_WRITE:
         syncHoodieTable(snapshotTableName, false, false);
@@ -128,14 +140,6 @@ public class HiveSyncTool extends AbstractSyncTool {
         throw new InvalidTableException(hoodieHiveClient.getBasePath());
     }
   }
-    } catch (RuntimeException re) {
-      throw new HoodieException("Got runtime exception when hive syncing " + cfg.tableName, re);
-    } finally {
-      if (hoodieHiveClient != null) {
-        hoodieHiveClient.close();
-      }
-    }
-  }
 
   protected void syncHoodieTable(String tableName, boolean useRealtimeInputFormat,
                                boolean readAsOptimized) {

hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/replication/GlobalHiveSyncTool.java

@@ -21,7 +21,6 @@ package org.apache.hudi.hive.replication;
 import org.apache.hudi.common.fs.FSUtils;
 import org.apache.hudi.common.model.HoodieTableType;
 import org.apache.hudi.common.util.Option;
-import org.apache.hudi.exception.InvalidTableException;
 import org.apache.hudi.hive.HiveSyncTool;
 
 import org.apache.hadoop.conf.Configuration;
@@ -43,20 +42,7 @@ public class GlobalHiveSyncTool extends HiveSyncTool {
 
   @Override
   public void syncHoodieTable() {
-    switch (hoodieHiveClient.getTableType()) {
+    doSync();
-      case COPY_ON_WRITE:
-        syncHoodieTable(snapshotTableName, false, false);
-        break;
-      case MERGE_ON_READ:
-        // sync a RO table for MOR
-        syncHoodieTable(roTableName.get(), false, true);
-        // sync a RT table for MOR
-        syncHoodieTable(snapshotTableName, true, false);
-        break;
-      default:
-        LOG.error("Unknown table type " + hoodieHiveClient.getTableType());
-        throw new InvalidTableException(hoodieHiveClient.getBasePath());
-    }
   }
 
   @Override