lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

Addressing comments

Browse Source
This commit is contained in:
Alex Filipchik
2019-08-27 15:31:04 -07:00
committed by Balaji Varadarajan
parent baea4f3b82
commit b5d4da7958
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
hudi-common/src/main/java/org/apache/hudi/common/util/CompactionUtils.java
View File

@@ -151,14 +151,15 @@ public class CompactionUtils {
return getPendingCompactionOperations(instantPlanPair.getKey(), instantPlanPair.getValue()); return getPendingCompactionOperations(instantPlanPair.getKey(), instantPlanPair.getValue());
}).forEach(pair -> { }).forEach(pair -> {
// Defensive check to ensure a single-fileId does not have more than one pending compaction with different // Defensive check to ensure a single-fileId does not have more than one pending compaction with different
// params. If we find a full dub we assume it is caused by eventual nature of the move operation on some DFSs. // file slices. If we find a full duplicate we assume it is caused by eventual nature of the move operation
// on some DFSs.
if (fgIdToPendingCompactionWithInstantMap.containsKey(pair.getKey())) { if (fgIdToPendingCompactionWithInstantMap.containsKey(pair.getKey())) {
HoodieCompactionOperation operation = pair.getValue().getValue(); HoodieCompactionOperation operation = pair.getValue().getValue();
HoodieCompactionOperation anotherOperation = HoodieCompactionOperation anotherOperation =
fgIdToPendingCompactionWithInstantMap.get(pair.getKey()).getValue(); fgIdToPendingCompactionWithInstantMap.get(pair.getKey()).getValue();
if (!operation.equals(anotherOperation)) { if (!operation.equals(anotherOperation)) {
String msg = "Hoodie File Id (" + pair.getKey() + ") has more thant 1 pending compactions. Instants: " String msg = "Hudi File Id (" + pair.getKey() + ") has more than 1 pending compactions. Instants: "
+ pair.getValue() + ", " + fgIdToPendingCompactionWithInstantMap.get(pair.getKey()); + pair.getValue() + ", " + fgIdToPendingCompactionWithInstantMap.get(pair.getKey());
throw new IllegalStateException(msg); throw new IllegalStateException(msg);
} }