lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-3193] Decouple hudi-aws from hudi-client-common (#5666)

Browse Source 
Move HoodieMetricsCloudWatchConfig to hudi-client-common
This commit is contained in:
Sagar Sumit
2022-05-25 19:38:56 +05:30
committed by GitHub
parent a6bc9e8e81
commit cf837b4900
6 changed files with 33 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hudi-aws/src/main/java/org/apache/hudi/aws/cloudwatch/CloudWatchReporter.java
View File

@@ -74,7 +74,7 @@ public class CloudWatchReporter extends ScheduledReporter {
}
public static class Builder {
private MetricRegistry registry;
private final MetricRegistry registry;
private Clock clock;
private String prefix;
private TimeUnit rateUnit;

87
hudi-aws/src/main/java/org/apache/hudi/config/HoodieMetricsCloudWatchConfig.java
View File

@@ -1,87 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hudi.config;
import org.apache.hudi.common.config.ConfigClassProperty;
import org.apache.hudi.common.config.ConfigGroups;
import org.apache.hudi.common.config.ConfigProperty;
import org.apache.hudi.common.config.HoodieConfig;
import java.util.Properties;
@ConfigClassProperty(
name = "Metrics Configurations for Amazon CloudWatch",
groupName = ConfigGroups.Names.METRICS,
description =
"Enables reporting on Hudi metrics using Amazon CloudWatch. "
+ " Hudi publishes metrics on every commit, clean, rollback etc.")
public class HoodieMetricsCloudWatchConfig extends HoodieConfig {
public static final String CLOUDWATCH_PREFIX = "hoodie.metrics.cloudwatch";
public static final ConfigProperty<Integer> REPORT_PERIOD_SECONDS = ConfigProperty
.key(CLOUDWATCH_PREFIX + ".report.period.seconds")
.defaultValue(60)
.sinceVersion("0.10.0")
.withDocumentation("Reporting interval in seconds");
public static final ConfigProperty<String> METRIC_PREFIX = ConfigProperty
.key(CLOUDWATCH_PREFIX + ".metric.prefix")
.defaultValue("")
.sinceVersion("0.10.0")
.withDocumentation("Metric prefix of reporter");
public static final ConfigProperty<String> METRIC_NAMESPACE = ConfigProperty
.key(CLOUDWATCH_PREFIX + ".namespace")
.defaultValue("Hudi")
.sinceVersion("0.10.0")
.withDocumentation("Namespace of reporter");
/*
Amazon CloudWatch allows a maximum of 20 metrics per request. Choosing this as the default maximum.
Reference: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_PutMetricData.html
*/
public static final ConfigProperty<Integer> MAX_DATUMS_PER_REQUEST =
ConfigProperty.key(CLOUDWATCH_PREFIX + ".maxDatumsPerRequest")
.defaultValue(20)
.sinceVersion("0.10.0")
.withDocumentation("Max number of Datums per request");
public HoodieMetricsCloudWatchConfig() {
super();
}
public static HoodieMetricsCloudWatchConfig.Builder newBuilder() {
return new HoodieMetricsCloudWatchConfig.Builder();
}
public static class Builder {
private HoodieMetricsCloudWatchConfig hoodieMetricsCloudWatchConfig = new HoodieMetricsCloudWatchConfig();
public HoodieMetricsCloudWatchConfig.Builder fromProperties(Properties props) {
this.hoodieMetricsCloudWatchConfig.getProps().putAll(props);
return this;
}
public HoodieMetricsCloudWatchConfig build() {
hoodieMetricsCloudWatchConfig.setDefaults(HoodieMetricsCloudWatchConfig.class.getName());
return hoodieMetricsCloudWatchConfig;
}
}
}