[HUDI-2767] Enabling timeline-server-based marker as default (#4112)
- Changes the default config of marker type (HoodieWriteConfig.MARKERS_TYPE or hoodie.write.markers.type) from DIRECT to TIMELINE_SERVER_BASED for Spark Engine. - Adds engine-specific marker type configs: Spark -> TIMELINE_SERVER_BASED, Flink -> DIRECT, Java -> DIRECT. - Uses DIRECT markers as well for Spark structured streaming due to timeline server only available for the first mini-batch. - Fixes the marker creation method for non-partitioned table in TimelineServerBasedWriteMarkers. - Adds the fallback to direct markers even when TIMELINE_SERVER_BASED is configured, in WriteMarkersFactory: when HDFS is used, or embedded timeline server is disabled, the fallback to direct markers happens. - Fixes the closing of timeline service. - Fixes tests that depend on markers, mainly by starting the timeline service for each test.
This commit is contained in:
@@ -321,8 +321,10 @@ public class TimelineService {
|
||||
if (requestHandler != null) {
|
||||
this.requestHandler.stop();
|
||||
}
|
||||
this.app.stop();
|
||||
this.app = null;
|
||||
if (this.app != null) {
|
||||
this.app.stop();
|
||||
this.app = null;
|
||||
}
|
||||
this.fsViewsManager.close();
|
||||
LOG.info("Closed Timeline Service");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user