lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

HUDI-171 delete tmp file in addShutDownHook

Browse Source
This commit is contained in:
garyli1019
2019-07-17 21:58:01 -07:00
committed by n3nash
parent ec965892b0
commit d288e32833
1 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
View File

@@ -56,6 +56,8 @@ public final class DiskBasedMap<T extends Serializable, R extends Serializable>
private static final Logger log = LogManager.getLogger(DiskBasedMap.class); private static final Logger log = LogManager.getLogger(DiskBasedMap.class);
// Stores the key and corresponding value's latest metadata spilled to disk // Stores the key and corresponding value's latest metadata spilled to disk
private final Map<T, ValueMetadata> valueMetadataMap; private final Map<T, ValueMetadata> valueMetadataMap;
// Write only file
private File writeOnlyFile;
// Write only OutputStream to be able to ONLY append to the file // Write only OutputStream to be able to ONLY append to the file
private SizeAwareDataOutputStream writeOnlyFileHandle; private SizeAwareDataOutputStream writeOnlyFileHandle;
// FileOutputStream for the file handle to be able to force fsync // FileOutputStream for the file handle to be able to force fsync
@@ -71,10 +73,10 @@ public final class DiskBasedMap<T extends Serializable, R extends Serializable>
public DiskBasedMap(String baseFilePath) throws IOException { public DiskBasedMap(String baseFilePath) throws IOException {
this.valueMetadataMap = new ConcurrentHashMap<>(); this.valueMetadataMap = new ConcurrentHashMap<>();
File writeOnlyFileHandle = new File(baseFilePath, UUID.randomUUID().toString()); this.writeOnlyFile = new File(baseFilePath, UUID.randomUUID().toString());
this.filePath = writeOnlyFileHandle.getPath(); this.filePath = writeOnlyFile.getPath();
initFile(writeOnlyFileHandle); initFile(writeOnlyFile);
this.fileOutputStream = new FileOutputStream(writeOnlyFileHandle, true); this.fileOutputStream = new FileOutputStream(writeOnlyFile, true);
this.writeOnlyFileHandle = new SizeAwareDataOutputStream(fileOutputStream); this.writeOnlyFileHandle = new SizeAwareDataOutputStream(fileOutputStream);
this.filePosition = new AtomicLong(0L); this.filePosition = new AtomicLong(0L);
} }
@@ -98,20 +100,20 @@ public final class DiskBasedMap<T extends Serializable, R extends Serializable>
} }
} }
private void initFile(File writeOnlyFileHandle) throws IOException { private void initFile(File writeOnlyFile) throws IOException {
// delete the file if it exists // delete the file if it exists
if (writeOnlyFileHandle.exists()) { if (writeOnlyFile.exists()) {
writeOnlyFileHandle.delete(); writeOnlyFile.delete();
} }
if (!writeOnlyFileHandle.getParentFile().exists()) { if (!writeOnlyFile.getParentFile().exists()) {
writeOnlyFileHandle.getParentFile().mkdir(); writeOnlyFile.getParentFile().mkdir();
} }
writeOnlyFileHandle.createNewFile(); writeOnlyFile.createNewFile();
log.info( log.info(
"Spilling to file location " + writeOnlyFileHandle.getAbsolutePath() + " in host (" + InetAddress.getLocalHost() "Spilling to file location " + writeOnlyFile.getAbsolutePath() + " in host (" + InetAddress.getLocalHost()
.getHostAddress() + ") with hostname (" + InetAddress.getLocalHost().getHostName() + ")"); .getHostAddress() + ") with hostname (" + InetAddress.getLocalHost().getHostName() + ")");
// Make sure file is deleted when JVM exits // Make sure file is deleted when JVM exits
writeOnlyFileHandle.deleteOnExit(); writeOnlyFile.deleteOnExit();
addShutDownHook(); addShutDownHook();
} }
@@ -139,8 +141,10 @@ public final class DiskBasedMap<T extends Serializable, R extends Serializable>
} }
} }
} }
writeOnlyFile.delete();
} catch (Exception e) { } catch (Exception e) {
// fail silently for any sort of exception // delete the file for any sort of exception
writeOnlyFile.delete();
} }
} }
}); });