Keep non-conflicting names for common configs between DataSourceOptions and HoodieWriteConfig (#3511)
This commit is contained in:
@@ -37,8 +37,8 @@ public abstract class BaseKeyGenerator extends KeyGenerator {
|
||||
super(config);
|
||||
this.encodePartitionPath = config.getBoolean(KeyGeneratorOptions.URL_ENCODE_PARTITIONING.key(),
|
||||
Boolean.parseBoolean(KeyGeneratorOptions.URL_ENCODE_PARTITIONING.defaultValue()));
|
||||
this.hiveStylePartitioning = config.getBoolean(KeyGeneratorOptions.HIVE_STYLE_PARTITIONING.key(),
|
||||
Boolean.parseBoolean(KeyGeneratorOptions.HIVE_STYLE_PARTITIONING.defaultValue()));
|
||||
this.hiveStylePartitioning = config.getBoolean(KeyGeneratorOptions.HIVE_STYLE_PARTITIONING_ENABLE.key(),
|
||||
Boolean.parseBoolean(KeyGeneratorOptions.HIVE_STYLE_PARTITIONING_ENABLE.defaultValue()));
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -36,21 +36,21 @@ public class KeyGeneratorOptions extends HoodieConfig {
|
||||
.defaultValue("false")
|
||||
.withDocumentation("Should we url encode the partition path value, before creating the folder structure.");
|
||||
|
||||
public static final ConfigProperty<String> HIVE_STYLE_PARTITIONING = ConfigProperty
|
||||
public static final ConfigProperty<String> HIVE_STYLE_PARTITIONING_ENABLE = ConfigProperty
|
||||
.key("hoodie.datasource.write.hive_style_partitioning")
|
||||
.defaultValue("false")
|
||||
.withDocumentation("Flag to indicate whether to use Hive style partitioning.\n"
|
||||
+ "If set true, the names of partition folders follow <partition_column_name>=<partition_value> format.\n"
|
||||
+ "By default false (the names of partition folders are only partition values)");
|
||||
|
||||
public static final ConfigProperty<String> RECORDKEY_FIELD = ConfigProperty
|
||||
public static final ConfigProperty<String> RECORDKEY_FIELD_NAME = ConfigProperty
|
||||
.key("hoodie.datasource.write.recordkey.field")
|
||||
.defaultValue("uuid")
|
||||
.withDocumentation("Record key field. Value to be used as the `recordKey` component of `HoodieKey`.\n"
|
||||
+ "Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using\n"
|
||||
+ "the dot notation eg: `a.b.c`");
|
||||
|
||||
public static final ConfigProperty<String> PARTITIONPATH_FIELD = ConfigProperty
|
||||
public static final ConfigProperty<String> PARTITIONPATH_FIELD_NAME = ConfigProperty
|
||||
.key("hoodie.datasource.write.partitionpath.field")
|
||||
.defaultValue("partitionpath")
|
||||
.withDocumentation("Partition path field. Value to be used at the partitionPath component of HoodieKey. "
|
||||
@@ -67,24 +67,24 @@ public class KeyGeneratorOptions extends HoodieConfig {
|
||||
@Deprecated
|
||||
public static final String DEFAULT_URL_ENCODE_PARTITIONING_OPT_VAL = URL_ENCODE_PARTITIONING.defaultValue();
|
||||
/**
|
||||
* @deprecated Use {@link #HIVE_STYLE_PARTITIONING} and its methods.
|
||||
* @deprecated Use {@link #HIVE_STYLE_PARTITIONING_ENABLE} and its methods.
|
||||
*/
|
||||
@Deprecated
|
||||
public static final String HIVE_STYLE_PARTITIONING_OPT_KEY = HIVE_STYLE_PARTITIONING.key();
|
||||
public static final String HIVE_STYLE_PARTITIONING_OPT_KEY = HIVE_STYLE_PARTITIONING_ENABLE.key();
|
||||
/**
|
||||
* @deprecated Use {@link #HIVE_STYLE_PARTITIONING} and its methods.
|
||||
* @deprecated Use {@link #HIVE_STYLE_PARTITIONING_ENABLE} and its methods.
|
||||
*/
|
||||
@Deprecated
|
||||
public static final String DEFAULT_HIVE_STYLE_PARTITIONING_OPT_VAL = HIVE_STYLE_PARTITIONING.defaultValue();
|
||||
public static final String DEFAULT_HIVE_STYLE_PARTITIONING_OPT_VAL = HIVE_STYLE_PARTITIONING_ENABLE.defaultValue();
|
||||
/**
|
||||
* @deprecated Use {@link #RECORDKEY_FIELD} and its methods.
|
||||
* @deprecated Use {@link #RECORDKEY_FIELD_NAME} and its methods.
|
||||
*/
|
||||
@Deprecated
|
||||
public static final String RECORDKEY_FIELD_OPT_KEY = RECORDKEY_FIELD.key();
|
||||
public static final String RECORDKEY_FIELD_OPT_KEY = RECORDKEY_FIELD_NAME.key();
|
||||
/**
|
||||
* @deprecated Use {@link #PARTITIONPATH_FIELD} and its methods.
|
||||
* @deprecated Use {@link #PARTITIONPATH_FIELD_NAME} and its methods.
|
||||
*/
|
||||
@Deprecated
|
||||
public static final String PARTITIONPATH_FIELD_OPT_KEY = PARTITIONPATH_FIELD.key();
|
||||
public static final String PARTITIONPATH_FIELD_OPT_KEY = PARTITIONPATH_FIELD_NAME.key();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user