From f73bedd374952580c4d6bc9b2e30607c4efdd538 Mon Sep 17 00:00:00 2001 From: wangxianghu Date: Sat, 26 Jun 2021 13:19:26 +0800 Subject: [PATCH] [MINOR] Remove unused methods (#3152) --- .../org/apache/hudi/util/StreamerUtil.java | 54 ------------------- 1 file changed, 54 deletions(-) diff --git a/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java b/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java index b49343d01..e20f34fa9 100644 --- a/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java +++ b/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java @@ -26,12 +26,7 @@ import org.apache.hudi.common.config.SerializableConfiguration; import org.apache.hudi.common.config.TypedProperties; import org.apache.hudi.common.engine.EngineType; import org.apache.hudi.common.fs.FSUtils; -import org.apache.hudi.common.model.HoodieRecordLocation; -import org.apache.hudi.common.model.HoodieRecordPayload; import org.apache.hudi.common.table.HoodieTableMetaClient; -import org.apache.hudi.common.util.Option; -import org.apache.hudi.common.util.ReflectionUtils; -import org.apache.hudi.common.util.TablePathUtils; import org.apache.hudi.config.HoodieCompactionConfig; import org.apache.hudi.config.HoodieMemoryConfig; import org.apache.hudi.config.HoodieStorageConfig; @@ -39,13 +34,11 @@ import org.apache.hudi.config.HoodieWriteConfig; import org.apache.hudi.configuration.FlinkOptions; import org.apache.hudi.exception.HoodieException; import org.apache.hudi.exception.HoodieIOException; -import org.apache.hudi.exception.TableNotFoundException; import org.apache.hudi.schema.FilebasedSchemaProvider; import org.apache.hudi.streamer.FlinkStreamerConfig; import org.apache.hudi.table.action.compact.CompactionTriggerStrategy; import org.apache.avro.Schema; -import org.apache.avro.generic.GenericRecord; import org.apache.flink.api.common.functions.RuntimeContext; import org.apache.flink.configuration.ConfigOption; import org.apache.flink.configuration.Configuration; @@ -61,7 +54,6 @@ import java.io.IOException; import java.io.StringReader; import java.util.List; import java.util.Locale; -import java.util.Objects; import java.util.Properties; import static org.apache.hudi.common.table.HoodieTableConfig.DEFAULT_ARCHIVELOG_FOLDER; @@ -136,23 +128,6 @@ public class StreamerUtil { return FlinkClientUtil.getHadoopConf(); } - /** - * Create a payload class via reflection, passing in an ordering/precombine value. - */ - public static HoodieRecordPayload createPayload(String payloadClass, GenericRecord record, Comparable orderingVal) - throws IOException { - try { - return (HoodieRecordPayload) ReflectionUtils.loadClass(payloadClass, - new Class[] {GenericRecord.class, Comparable.class}, record, orderingVal); - } catch (Throwable e) { - throw new IOException("Could not create payload for class: " + payloadClass, e); - } - } - - public static HoodieWriteConfig getHoodieClientConfig(FlinkStreamerConfig conf) { - return getHoodieClientConfig(FlinkStreamerConfig.toFlinkConfig(conf)); - } - public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) { HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder() @@ -251,27 +226,6 @@ public class StreamerUtil { return String.format("%s_%s", partitionPath, fileId); } - /** Returns whether the location represents an insert. */ - public static boolean isInsert(HoodieRecordLocation loc) { - return Objects.equals(loc.getInstantTime(), "I"); - } - - public static String getTablePath(FileSystem fs, Path[] userProvidedPaths) throws IOException { - LOG.info("Getting table path.."); - for (Path path : userProvidedPaths) { - try { - Option tablePath = TablePathUtils.getTablePath(fs, path); - if (tablePath.isPresent()) { - return tablePath.get().toString(); - } - } catch (HoodieException he) { - LOG.warn("Error trying to get table path from " + path.toString(), he); - } - } - - throw new TableNotFoundException("Unable to find a hudi table for the user provided paths."); - } - /** * Returns whether needs to schedule the async compaction. * @param conf The flink configuration. @@ -295,14 +249,6 @@ public class StreamerUtil { return new HoodieFlinkWriteClient<>(context, getHoodieClientConfig(conf)); } - /** - * Plus the old instant time with given milliseconds and returns. - */ - public static String instantTimePlus(String oldInstant, long milliseconds) { - long oldTime = Long.parseLong(oldInstant); - return String.valueOf(oldTime + milliseconds); - } - /** * Return the median instant time between the given two instant time. */