refactor: 后端代码质量优化 - 复用公共库、使用标准库、类型安全错误判断
## 高优先级修复 - stats_service_impl: 使用 strings.SplitN 替代错误的索引分割 - provider_handler: 使用 errors.Is(err, gorm.ErrDuplicatedKey) 替代字符串匹配 - client: 重写 isNetworkError 使用 errors.As/Is 类型安全判断 - proxy_handler: 使用 encoding/json 标准库解析 JSON(extractModelName、isStreamRequest) ## 中优先级修复 - stats_handler: 添加 parseDateParam 辅助函数消除重复日期解析 - pkg/errors: 新增 ErrRequestCreate/Send/ResponseRead 错误类型和 WithCause 方法 - client: 使用结构化错误替代 fmt.Errorf - ConversionEngine: logger 依赖注入,替换所有 zap.L() 调用 ## 低优先级修复 - encoder: 删除 joinStrings,使用 strings.Join - adapter: 删除 modelInfoRegex 正则,使用 isModelInfoPath 字符串函数 ## 文档更新 - README.md: 添加公共库使用指南和编码规范章节 - specs: 同步 delta specs 到 main specs(error-handling、structured-logging、request-validation) ## 归档 - openspec/changes/archive/2026-04-20-refactor-backend-code-quality/
This commit is contained in:
@@ -2,9 +2,12 @@ package provider
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"errors"
|
||||
"io"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"syscall"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
@@ -309,22 +312,49 @@ func TestClient_SendStream_SplitSSEEvents(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestIsNetworkError(t *testing.T) {
|
||||
tests := []struct {
|
||||
input string
|
||||
want bool
|
||||
}{
|
||||
{"connection reset by peer", true},
|
||||
{"broken pipe", true},
|
||||
{"network is unreachable", true},
|
||||
{"timeout waiting for response", true},
|
||||
{"unexpected EOF", true},
|
||||
{"normal error", false},
|
||||
{"", false},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
err := fmt.Errorf("%s", tt.input)
|
||||
assert.Equal(t, tt.want, isNetworkError(err), "isNetworkError(%q)", tt.input)
|
||||
}
|
||||
// 测试 net.Error 类型
|
||||
t.Run("net_error", func(t *testing.T) {
|
||||
var netErr net.Error
|
||||
err := context.DeadlineExceeded
|
||||
assert.True(t, errors.As(err, &netErr))
|
||||
assert.True(t, isNetworkError(err))
|
||||
})
|
||||
|
||||
// 测试 io.EOF
|
||||
t.Run("io_eof", func(t *testing.T) {
|
||||
assert.True(t, isNetworkError(io.EOF))
|
||||
})
|
||||
|
||||
// 测试 context 错误
|
||||
t.Run("context_errors", func(t *testing.T) {
|
||||
assert.True(t, isNetworkError(context.DeadlineExceeded))
|
||||
assert.True(t, isNetworkError(context.Canceled))
|
||||
})
|
||||
|
||||
// 测试 syscall 错误(包装在 net.OpError 中)
|
||||
t.Run("syscall_errors", func(t *testing.T) {
|
||||
// ECONNRESET
|
||||
opErr := &net.OpError{
|
||||
Op: "read",
|
||||
Net: "tcp",
|
||||
Err: syscall.ECONNRESET,
|
||||
}
|
||||
assert.True(t, isNetworkError(opErr))
|
||||
|
||||
// EPIPE
|
||||
opErr = &net.OpError{
|
||||
Op: "write",
|
||||
Net: "tcp",
|
||||
Err: syscall.EPIPE,
|
||||
}
|
||||
assert.True(t, isNetworkError(opErr))
|
||||
})
|
||||
|
||||
// 测试普通错误
|
||||
t.Run("normal_error", func(t *testing.T) {
|
||||
assert.False(t, isNetworkError(errors.New("normal error")))
|
||||
assert.False(t, isNetworkError(nil))
|
||||
})
|
||||
}
|
||||
|
||||
func TestClient_SendStream_MidStreamNetworkError(t *testing.T) {
|
||||
|
||||
Reference in New Issue
Block a user