## 高优先级修复 - stats_service_impl: 使用 strings.SplitN 替代错误的索引分割 - provider_handler: 使用 errors.Is(err, gorm.ErrDuplicatedKey) 替代字符串匹配 - client: 重写 isNetworkError 使用 errors.As/Is 类型安全判断 - proxy_handler: 使用 encoding/json 标准库解析 JSON(extractModelName、isStreamRequest) ## 中优先级修复 - stats_handler: 添加 parseDateParam 辅助函数消除重复日期解析 - pkg/errors: 新增 ErrRequestCreate/Send/ResponseRead 错误类型和 WithCause 方法 - client: 使用结构化错误替代 fmt.Errorf - ConversionEngine: logger 依赖注入,替换所有 zap.L() 调用 ## 低优先级修复 - encoder: 删除 joinStrings,使用 strings.Join - adapter: 删除 modelInfoRegex 正则,使用 isModelInfoPath 字符串函数 ## 文档更新 - README.md: 添加公共库使用指南和编码规范章节 - specs: 同步 delta specs 到 main specs(error-handling、structured-logging、request-validation) ## 归档 - openspec/changes/archive/2026-04-20-refactor-backend-code-quality/
324 lines
12 KiB
Go
324 lines
12 KiB
Go
package conversion
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
|
|
"nex/backend/internal/conversion/canonical"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestConversionError_WithProviderProtocol(t *testing.T) {
|
|
err := NewConversionError(ErrorCodeInvalidInput, "test").WithProviderProtocol("anthropic")
|
|
assert.Equal(t, "anthropic", err.ProviderProtocol)
|
|
}
|
|
|
|
func TestConversionError_WithInterfaceType(t *testing.T) {
|
|
err := NewConversionError(ErrorCodeInvalidInput, "test").WithInterfaceType("CHAT")
|
|
assert.Equal(t, "CHAT", err.InterfaceType)
|
|
}
|
|
|
|
func TestConversionError_FullBuilder(t *testing.T) {
|
|
err := NewConversionError(ErrorCodeInvalidInput, "bad").
|
|
WithClientProtocol("openai").
|
|
WithProviderProtocol("anthropic").
|
|
WithInterfaceType("CHAT").
|
|
WithDetail("field", "model").
|
|
WithCause(errors.New("root"))
|
|
|
|
assert.Equal(t, ErrorCodeInvalidInput, err.Code)
|
|
assert.Equal(t, "openai", err.ClientProtocol)
|
|
assert.Equal(t, "anthropic", err.ProviderProtocol)
|
|
assert.Equal(t, "CHAT", err.InterfaceType)
|
|
assert.Equal(t, "model", err.Details["field"])
|
|
assert.Equal(t, "root", err.Cause.Error())
|
|
}
|
|
|
|
func TestEngine_Use(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
called := false
|
|
engine.Use(&testMiddleware{fn: func(req *canonical.CanonicalRequest, cp, pp string, ctx *ConversionContext) (*canonical.CanonicalRequest, error) {
|
|
called = true
|
|
return req, nil
|
|
}})
|
|
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.decodeReqFn = func(raw []byte) (*canonical.CanonicalRequest, error) {
|
|
return &canonical.CanonicalRequest{Model: "test"}, nil
|
|
}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.encodeReqFn = func(req *canonical.CanonicalRequest, p *TargetProvider) ([]byte, error) {
|
|
return json.Marshal(req)
|
|
}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
_, err := engine.ConvertHttpRequest(HTTPRequestSpec{
|
|
URL: "/v1/chat/completions", Method: "POST", Body: []byte(`{}`),
|
|
}, "client", "provider", NewTargetProvider("https://example.com", "key", "model"))
|
|
require.NoError(t, err)
|
|
assert.True(t, called)
|
|
}
|
|
|
|
func TestConvertHttpRequest_DecodeError(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.decodeReqFn = func(raw []byte) (*canonical.CanonicalRequest, error) {
|
|
return nil, errors.New("decode failed")
|
|
}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(newMockAdapter("provider", false))
|
|
|
|
_, err := engine.ConvertHttpRequest(HTTPRequestSpec{
|
|
URL: "/v1/chat/completions", Method: "POST", Body: []byte(`{}`),
|
|
}, "client", "provider", NewTargetProvider("", "", ""))
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestConvertHttpRequest_EncodeError(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
_ = engine.RegisterAdapter(newMockAdapter("client", false))
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.encodeReqFn = func(req *canonical.CanonicalRequest, p *TargetProvider) ([]byte, error) {
|
|
return nil, errors.New("encode failed")
|
|
}
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
_, err := engine.ConvertHttpRequest(HTTPRequestSpec{
|
|
URL: "/v1/chat/completions", Method: "POST", Body: []byte(`{}`),
|
|
}, "client", "provider", NewTargetProvider("", "", ""))
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestConvertHttpResponse_CrossProtocol(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.encodeRespFn = func(resp *canonical.CanonicalResponse) ([]byte, error) {
|
|
return json.Marshal(map[string]string{"id": resp.ID})
|
|
}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.decodeRespFn = func(raw []byte) (*canonical.CanonicalResponse, error) {
|
|
return &canonical.CanonicalResponse{ID: "resp-1", Model: "test"}, nil
|
|
}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpResponse(HTTPResponseSpec{
|
|
StatusCode: 200, Body: []byte(`{"id":"resp-1"}`),
|
|
}, "client", "provider", InterfaceTypeChat)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 200, result.StatusCode)
|
|
assert.Contains(t, string(result.Body), "resp-1")
|
|
}
|
|
|
|
func TestConvertHttpResponse_DecodeError(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.decodeRespFn = func(raw []byte) (*canonical.CanonicalResponse, error) {
|
|
return nil, errors.New("decode error")
|
|
}
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
_ = engine.RegisterAdapter(newMockAdapter("client", false))
|
|
|
|
_, err := engine.ConvertHttpResponse(HTTPResponseSpec{Body: []byte(`{}`)}, "client", "provider", InterfaceTypeChat)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestConvertHttpRequest_EmbeddingInterface(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.ifaceType = InterfaceTypeEmbeddings
|
|
clientAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeEmbeddings: true}
|
|
clientAdapter.decodeReqFn = func(raw []byte) (*canonical.CanonicalRequest, error) {
|
|
return &canonical.CanonicalRequest{Model: "test"}, nil
|
|
}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.ifaceType = InterfaceTypeEmbeddings
|
|
providerAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeEmbeddings: true}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpRequest(HTTPRequestSpec{
|
|
URL: "/v1/embeddings", Method: "POST", Body: []byte(`{"model":"text-embedding","input":"hello"}`),
|
|
}, "client", "provider", NewTargetProvider("https://example.com", "key", "model"))
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|
|
|
|
func TestConvertHttpRequest_RerankInterface(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.ifaceType = InterfaceTypeRerank
|
|
clientAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeRerank: true}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.ifaceType = InterfaceTypeRerank
|
|
providerAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeRerank: true}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpRequest(HTTPRequestSpec{
|
|
URL: "/v1/rerank", Method: "POST", Body: []byte(`{"model":"rerank","query":"test","documents":["a"]}`),
|
|
}, "client", "provider", NewTargetProvider("https://example.com", "key", "model"))
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|
|
|
|
func TestConvertHttpResponse_EmbeddingInterface(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeEmbeddings: true}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeEmbeddings: true}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpResponse(HTTPResponseSpec{
|
|
StatusCode: 200, Body: []byte(`{"object":"list","data":[],"model":"test"}`),
|
|
}, "client", "provider", InterfaceTypeEmbeddings)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|
|
|
|
func TestConvertHttpResponse_RerankInterface(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeRerank: true}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeRerank: true}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpResponse(HTTPResponseSpec{
|
|
StatusCode: 200, Body: []byte(`{"results":[],"model":"test"}`),
|
|
}, "client", "provider", InterfaceTypeRerank)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|
|
|
|
func TestConvertHttpRequest_ModelsInterface_Passthrough(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.ifaceType = InterfaceTypeModels
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.ifaceType = InterfaceTypeModels
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
body := []byte(`{"object":"list","data":[]}`)
|
|
result, err := engine.ConvertHttpRequest(HTTPRequestSpec{
|
|
URL: "/v1/models", Method: "GET", Body: body,
|
|
}, "client", "provider", NewTargetProvider("https://example.com", "key", ""))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, body, result.Body)
|
|
}
|
|
|
|
func TestConvertHttpResponse_ModelsInterface(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeModels: true}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeModels: true}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpResponse(HTTPResponseSpec{
|
|
StatusCode: 200, Body: []byte(`{"object":"list","data":[]}`),
|
|
}, "client", "provider", InterfaceTypeModels)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|
|
|
|
func TestConvertHttpResponse_ModelInfoInterface(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
engine := NewConversionEngine(registry, nil)
|
|
clientAdapter := newMockAdapter("client", false)
|
|
clientAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeModelInfo: true}
|
|
providerAdapter := newMockAdapter("provider", false)
|
|
providerAdapter.supportsIface = map[InterfaceType]bool{InterfaceTypeModelInfo: true}
|
|
_ = engine.RegisterAdapter(clientAdapter)
|
|
_ = engine.RegisterAdapter(providerAdapter)
|
|
|
|
result, err := engine.ConvertHttpResponse(HTTPResponseSpec{
|
|
StatusCode: 200, Body: []byte(`{"id":"gpt-4","object":"model"}`),
|
|
}, "client", "provider", InterfaceTypeModelInfo)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|
|
|
|
func TestRegistry_ListProtocols(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
_ = registry.Register(newMockAdapter("openai", true))
|
|
_ = registry.Register(newMockAdapter("anthropic", true))
|
|
|
|
protocols := registry.ListProtocols()
|
|
assert.Len(t, protocols, 2)
|
|
assert.Contains(t, protocols, "openai")
|
|
assert.Contains(t, protocols, "anthropic")
|
|
}
|
|
|
|
func TestRegistry_ConcurrentAccess(t *testing.T) {
|
|
registry := NewMemoryRegistry()
|
|
done := make(chan bool, 2)
|
|
|
|
go func() {
|
|
for i := 0; i < 100; i++ {
|
|
_ = registry.Register(newMockAdapter("proto-"+string(rune(i)), true))
|
|
}
|
|
done <- true
|
|
}()
|
|
|
|
go func() {
|
|
for i := 0; i < 100; i++ {
|
|
_, _ = registry.Get("proto-" + string(rune(i)))
|
|
}
|
|
_ = registry.ListProtocols()
|
|
done <- true
|
|
}()
|
|
|
|
<-done
|
|
<-done
|
|
}
|
|
|
|
func TestNewConversionContext(t *testing.T) {
|
|
ctx := NewConversionContext(InterfaceTypeChat)
|
|
assert.NotEmpty(t, ctx.ConversionID)
|
|
assert.Equal(t, InterfaceTypeChat, ctx.InterfaceType)
|
|
assert.NotNil(t, ctx.Metadata)
|
|
}
|
|
|
|
type testMiddleware struct {
|
|
fn func(req *canonical.CanonicalRequest, clientProtocol, providerProtocol string, ctx *ConversionContext) (*canonical.CanonicalRequest, error)
|
|
}
|
|
|
|
func (m *testMiddleware) Intercept(req *canonical.CanonicalRequest, clientProtocol, providerProtocol string, ctx *ConversionContext) (*canonical.CanonicalRequest, error) {
|
|
if m.fn != nil {
|
|
return m.fn(req, clientProtocol, providerProtocol, ctx)
|
|
}
|
|
return req, nil
|
|
}
|
|
|
|
func (m *testMiddleware) InterceptStreamEvent(event *canonical.CanonicalStreamEvent, clientProtocol, providerProtocol string, ctx *ConversionContext) (*canonical.CanonicalStreamEvent, error) {
|
|
return event, nil
|
|
}
|
|
|
|
var _ = json.Marshal
|