lanyuanxiaoyao
d92db73937
## 高优先级修复 - stats_service_impl: 使用 strings.SplitN 替代错误的索引分割 - provider_handler: 使用 errors.Is(err, gorm.ErrDuplicatedKey) 替代字符串匹配 - client: 重写 isNetworkError 使用 errors.As/Is 类型安全判断 - proxy_handler: 使用 encoding/json 标准库解析 JSON（extractModelName、isStreamRequest） ## 中优先级修复 - stats_handler: 添加 parseDateParam 辅助函数消除重复日期解析 - pkg/errors: 新增 ErrRequestCreate/Send/ResponseRead 错误类型和 WithCause 方法 - client: 使用结构化错误替代 fmt.Errorf - ConversionEngine: logger 依赖注入，替换所有 zap.L() 调用 ## 低优先级修复 - encoder: 删除 joinStrings，使用 strings.Join - adapter: 删除 modelInfoRegex 正则，使用 isModelInfoPath 字符串函数 ## 文档更新 - README.md: 添加公共库使用指南和编码规范章节 - specs: 同步 delta specs 到 main specs（error-handling、structured-logging、request-validation） ## 归档 - openspec/changes/archive/2026-04-20-refactor-backend-code-quality/
135 lines
4.0 KiB
Go
135 lines
4.0 KiB
Go
package service
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"nex/backend/internal/domain"
|
|
"nex/backend/internal/repository"
|
|
)
|
|
|
|
func TestProviderService_Update(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
repo := repository.NewProviderRepository(db)
|
|
svc := NewProviderService(repo)
|
|
|
|
svc.Create(&domain.Provider{ID: "p1", Name: "Original", APIKey: "key", BaseURL: "https://test.com"})
|
|
|
|
err := svc.Update("p1", map[string]interface{}{"name": "Updated"})
|
|
require.NoError(t, err)
|
|
|
|
result, err := svc.Get("p1", false)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "Updated", result.Name)
|
|
}
|
|
|
|
func TestProviderService_Update_NotFound(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
repo := repository.NewProviderRepository(db)
|
|
svc := NewProviderService(repo)
|
|
|
|
err := svc.Update("nonexistent", map[string]interface{}{"name": "test"})
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestModelService_Get(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
providerRepo := repository.NewProviderRepository(db)
|
|
modelRepo := repository.NewModelRepository(db)
|
|
svc := NewModelService(modelRepo, providerRepo)
|
|
|
|
providerRepo.Create(&domain.Provider{ID: "p1", Name: "P1", APIKey: "key", BaseURL: "https://test.com"})
|
|
svc.Create(&domain.Model{ID: "m1", ProviderID: "p1", ModelName: "gpt-4"})
|
|
|
|
model, err := svc.Get("m1")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "gpt-4", model.ModelName)
|
|
}
|
|
|
|
func TestModelService_Update(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
providerRepo := repository.NewProviderRepository(db)
|
|
modelRepo := repository.NewModelRepository(db)
|
|
svc := NewModelService(modelRepo, providerRepo)
|
|
|
|
providerRepo.Create(&domain.Provider{ID: "p1", Name: "P1", APIKey: "key", BaseURL: "https://test.com"})
|
|
svc.Create(&domain.Model{ID: "m1", ProviderID: "p1", ModelName: "gpt-4"})
|
|
|
|
err := svc.Update("m1", map[string]interface{}{"model_name": "gpt-4o"})
|
|
require.NoError(t, err)
|
|
|
|
model, err := svc.Get("m1")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "gpt-4o", model.ModelName)
|
|
}
|
|
|
|
func TestModelService_Update_ProviderID_Invalid(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
providerRepo := repository.NewProviderRepository(db)
|
|
modelRepo := repository.NewModelRepository(db)
|
|
svc := NewModelService(modelRepo, providerRepo)
|
|
|
|
providerRepo.Create(&domain.Provider{ID: "p1", Name: "P1", APIKey: "key", BaseURL: "https://test.com"})
|
|
svc.Create(&domain.Model{ID: "m1", ProviderID: "p1", ModelName: "gpt-4"})
|
|
|
|
err := svc.Update("m1", map[string]interface{}{"provider_id": "nonexistent"})
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestModelService_Delete(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
providerRepo := repository.NewProviderRepository(db)
|
|
modelRepo := repository.NewModelRepository(db)
|
|
svc := NewModelService(modelRepo, providerRepo)
|
|
|
|
providerRepo.Create(&domain.Provider{ID: "p1", Name: "P1", APIKey: "key", BaseURL: "https://test.com"})
|
|
svc.Create(&domain.Model{ID: "m1", ProviderID: "p1", ModelName: "gpt-4"})
|
|
|
|
err := svc.Delete("m1")
|
|
require.NoError(t, err)
|
|
|
|
_, err = svc.Get("m1")
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestModelService_Delete_NotFound(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
modelRepo := repository.NewModelRepository(db)
|
|
providerRepo := repository.NewProviderRepository(db)
|
|
svc := NewModelService(modelRepo, providerRepo)
|
|
|
|
err := svc.Delete("nonexistent")
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestStatsService_Aggregate_Default(t *testing.T) {
|
|
statsRepo := repository.NewStatsRepository(nil)
|
|
svc := NewStatsService(statsRepo)
|
|
|
|
stats := []domain.UsageStats{
|
|
{ProviderID: "p1", RequestCount: 10},
|
|
{ProviderID: "p2", RequestCount: 5},
|
|
}
|
|
|
|
result := svc.Aggregate(stats, "")
|
|
assert.Len(t, result, 2)
|
|
|
|
totalCount := 0
|
|
for _, r := range result {
|
|
totalCount += r["request_count"].(int)
|
|
}
|
|
assert.Equal(t, 15, totalCount)
|
|
}
|
|
|
|
func TestModelService_Update_NotFound(t *testing.T) {
|
|
db := setupServiceTestDB(t)
|
|
modelRepo := repository.NewModelRepository(db)
|
|
providerRepo := repository.NewProviderRepository(db)
|
|
svc := NewModelService(modelRepo, providerRepo)
|
|
|
|
err := svc.Update("nonexistent", map[string]interface{}{"model_name": "test"})
|
|
assert.Error(t, err)
|
|
}
|