1
0
Files
nex/backend/internal/handler/stats_handler_test.go
lanyuanxiaoyao d92db73937 refactor: 后端代码质量优化 - 复用公共库、使用标准库、类型安全错误判断
## 高优先级修复
- stats_service_impl: 使用 strings.SplitN 替代错误的索引分割
- provider_handler: 使用 errors.Is(err, gorm.ErrDuplicatedKey) 替代字符串匹配
- client: 重写 isNetworkError 使用 errors.As/Is 类型安全判断
- proxy_handler: 使用 encoding/json 标准库解析 JSON(extractModelName、isStreamRequest)

## 中优先级修复
- stats_handler: 添加 parseDateParam 辅助函数消除重复日期解析
- pkg/errors: 新增 ErrRequestCreate/Send/ResponseRead 错误类型和 WithCause 方法
- client: 使用结构化错误替代 fmt.Errorf
- ConversionEngine: logger 依赖注入,替换所有 zap.L() 调用

## 低优先级修复
- encoder: 删除 joinStrings,使用 strings.Join
- adapter: 删除 modelInfoRegex 正则,使用 isModelInfoPath 字符串函数

## 文档更新
- README.md: 添加公共库使用指南和编码规范章节
- specs: 同步 delta specs 到 main specs(error-handling、structured-logging、request-validation)

## 归档
- openspec/changes/archive/2026-04-20-refactor-backend-code-quality/
2026-04-20 16:42:48 +08:00

62 lines
1.6 KiB
Go

package handler
import (
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/gin-gonic/gin"
"github.com/stretchr/testify/assert"
)
func TestParseDateParam(t *testing.T) {
gin.SetMode(gin.TestMode)
t.Run("valid_date", func(t *testing.T) {
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = httptest.NewRequest(http.MethodGet, "/?start_date=2024-01-15", nil)
result, err := parseDateParam(c, "start_date")
assert.NoError(t, err)
assert.NotNil(t, result)
expected := time.Date(2024, 1, 15, 0, 0, 0, 0, time.UTC)
assert.Equal(t, expected, *result)
})
t.Run("empty_param", func(t *testing.T) {
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = httptest.NewRequest(http.MethodGet, "/", nil)
result, err := parseDateParam(c, "start_date")
assert.NoError(t, err)
assert.Nil(t, result)
})
t.Run("invalid_format", func(t *testing.T) {
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = httptest.NewRequest(http.MethodGet, "/?start_date=2024/01/15", nil)
result, err := parseDateParam(c, "start_date")
assert.Error(t, err)
assert.Nil(t, result)
assert.Contains(t, err.Error(), "start_date")
assert.Contains(t, err.Error(), "YYYY-MM-DD")
})
t.Run("end_date", func(t *testing.T) {
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = httptest.NewRequest(http.MethodGet, "/?end_date=2024-12-31", nil)
result, err := parseDateParam(c, "end_date")
assert.NoError(t, err)
assert.NotNil(t, result)
expected := time.Date(2024, 12, 31, 0, 0, 0, 0, time.UTC)
assert.Equal(t, expected, *result)
})
}