lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[MINOR] Adding timeout for each command execution in docker and capture output. This will help get stdout/stderr of stuck commands (#1918)

Browse Source
This commit is contained in:
Balaji Varadarajan
2020-08-05 07:46:34 -07:00
committed by GitHub
parent 217a84192c
commit 61e027fadd
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
View File

@@ -18,6 +18,8 @@
package org.apache.hudi.integ;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import org.apache.hudi.common.util.FileIOUtils;
import org.apache.hudi.common.util.collection.Pair;
@@ -158,8 +160,21 @@ public abstract class ITTestBase {
ExecCreateCmdResponse createCmdResponse = cmd.exec();
TestExecStartResultCallback callback =
new TestExecStartResultCallback(new ByteArrayOutputStream(), new ByteArrayOutputStream());
dockerClient.execStartCmd(createCmdResponse.getId()).withDetach(false).withTty(false).exec(callback)
.awaitCompletion();
// Each execution of command(s) in docker should not be more than 15 mins. Otherwise, it is deemed stuck. We will
// try to capture stdout and stderr of the stuck process.
boolean completed =
dockerClient.execStartCmd(createCmdResponse.getId()).withDetach(false).withTty(false).exec(callback)
.awaitCompletion(900, SECONDS);
if (!completed) {
callback.getStderr().flush();
callback.getStdout().flush();
LOG.error("\n\n ###### Timed Out Command : " + Arrays.asList(command));
LOG.error("\n\n ###### Stderr of timed-out command #######\n" + callback.getStderr().toString());
LOG.error("\n\n ###### stdout of timed-out command #######\n" + callback.getStderr().toString());
throw new TimeoutException("Command " + command + " has been running for more than 15 minutes. "
+ "Killing and failing !!");
}
int exitCode = dockerClient.inspectExecCmd(createCmdResponse.getId()).exec().getExitCode();
LOG.info("Exit code for command : " + exitCode);
if (exitCode != 0) {