lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-3412] TypedProperties no need to create new set when check key exist or not (#4791)

Browse Source 
Co-authored-by: Hui An <hui.an@shopee.com>
This commit is contained in:
RexAn
2022-02-14 11:33:29 +08:00
committed by GitHub
parent 76e2faa28d
commit 93ee09fee8
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
hudi-common/src/main/java/org/apache/hudi/common/config/TypedProperties.java
View File

@@ -23,7 +23,6 @@ import java.util.Arrays;
import java.util.List;
import java.util.Objects;
import java.util.Properties;
import java.util.Set;
import java.util.stream.Collectors;
/**
@@ -44,27 +43,22 @@ public class TypedProperties extends Properties implements Serializable {
}
private void checkKey(String property) {
if (!keyExists(property)) {
if (!containsKey(property)) {
throw new IllegalArgumentException("Property " + property + " not found");
}
}
private boolean keyExists(String property) {
Set<String> keys = super.stringPropertyNames();
return keys.contains(property);
}
public String getString(String property) {
checkKey(property);
return getProperty(property);
}
public String getString(String property, String defaultValue) {
return keyExists(property) ? getProperty(property) : defaultValue;
return containsKey(property) ? getProperty(property) : defaultValue;
}
public List<String> getStringList(String property, String delimiter, List<String> defaultVal) {
if (!keyExists(property)) {
if (!containsKey(property)) {
return defaultVal;
}
return Arrays.stream(getProperty(property).split(delimiter)).map(String::trim).collect(Collectors.toList());
@@ -76,7 +70,7 @@ public class TypedProperties extends Properties implements Serializable {
}
public int getInteger(String property, int defaultValue) {
return keyExists(property) ? Integer.parseInt(getProperty(property)) : defaultValue;
return containsKey(property) ? Integer.parseInt(getProperty(property)) : defaultValue;
}
public long getLong(String property) {
@@ -85,7 +79,7 @@ public class TypedProperties extends Properties implements Serializable {
}
public long getLong(String property, long defaultValue) {
return keyExists(property) ? Long.parseLong(getProperty(property)) : defaultValue;
return containsKey(property) ? Long.parseLong(getProperty(property)) : defaultValue;
}
public boolean getBoolean(String property) {
@@ -94,7 +88,7 @@ public class TypedProperties extends Properties implements Serializable {
}
public boolean getBoolean(String property, boolean defaultValue) {
return keyExists(property) ? Boolean.parseBoolean(getProperty(property)) : defaultValue;
return containsKey(property) ? Boolean.parseBoolean(getProperty(property)) : defaultValue;
}
public double getDouble(String property) {
@@ -103,6 +97,6 @@ public class TypedProperties extends Properties implements Serializable {
}
public double getDouble(String property, double defaultValue) {
return keyExists(property) ? Double.parseDouble(getProperty(property)) : defaultValue;
return containsKey(property) ? Double.parseDouble(getProperty(property)) : defaultValue;
}
}