lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics (#1732)

Browse Source
This commit is contained in:
Shen Hong
2020-07-07 00:44:02 +08:00
committed by GitHub
parent 3b9a30528b
commit be85a6c32b
2 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
hudi-client/src/main/java/org/apache/hudi/metrics/HoodieGauge.java Normal file
View File

@@ -0,0 +1,52 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hudi.metrics;
import com.codahale.metrics.Gauge;
/**
* Similar to {@link Gauge}, but metric value can be updated by {@link #setValue(T)}.
*/
public class HoodieGauge<T> implements Gauge<T> {
private volatile T value;
/**
* Create an instance with a default value.
*/
public HoodieGauge(T value) {
this.value = value;
}
/**
* Set the metric to a new value.
*/
public void setValue(T value) {
this.value = value;
}
/**
* Returns the metric's current value.
*
* @return the metric's current value
*/
@Override
public T getValue() {
return value;
}
}

4
hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java
View File

@@ -21,7 +21,6 @@ package org.apache.hudi.metrics;
import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.exception.HoodieException;
import com.codahale.metrics.Gauge;
import com.codahale.metrics.MetricRegistry;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
@@ -81,7 +80,8 @@ public class Metrics {
public static void registerGauge(String metricName, final long value) {
try {
MetricRegistry registry = Metrics.getInstance().getRegistry();
registry.<Gauge<Long>>register(metricName, () -> value);
HoodieGauge guage = (HoodieGauge) registry.gauge(metricName, () -> new HoodieGauge<>(value));
guage.setValue(value);
} catch (Exception e) {
// Here we catch all exception, so the major upsert pipeline will not be affected if the
// metrics system