lanyuanxiaoyao/hudi
1
0
Fork 0
Code Activity

[HUDI-3730] Add ConfigTool#toMap UT (#6035)

Browse Source 
Co-authored-by: voonhou.su <voonhou.su@shopee.com>
This commit is contained in:
voonhous
2022-07-05 06:07:19 +08:00
committed by GitHub
parent e0954040a9
commit c091e4cc30
2 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/util/ConfigUtils.java
View File

@@ -47,6 +47,10 @@ public class ConfigUtils {
String[] keyvalues = keyValueConfig.split("\n");
Map<String, String> tableProperties = new HashMap<>();
for (String keyValue : keyvalues) {
// Handle multiple new lines and lines that contain only spaces after splitting
if (keyValue.trim().isEmpty()) {
continue;
}
String[] keyValueArray = keyValue.split("=");
if (keyValueArray.length == 1 || keyValueArray.length == 2) {
String key = keyValueArray[0].trim();

50
hudi-sync/hudi-sync-common/src/test/java/org/apache/hudi/sync/common/util/TestConfigUtils.java Normal file
View File

@@ -0,0 +1,50 @@
package org.apache.hudi.sync.common.util;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import java.util.HashMap;
import java.util.Map;
import org.junit.jupiter.api.Test;
public class TestConfigUtils {
@Test
public void testToMapSucceeds() {
Map<String, String> expectedMap = new HashMap<>();
expectedMap.put("k.1.1.2", "v1");
expectedMap.put("k.2.1.2", "v2");
expectedMap.put("k.3.1.2", "v3");
// Test base case
String srcKv = "k.1.1.2=v1\nk.2.1.2=v2\nk.3.1.2=v3";
Map<String, String> outMap = ConfigUtils.toMap(srcKv);
assertEquals(expectedMap, outMap);
// Test ends with new line
srcKv = "k.1.1.2=v1\nk.2.1.2=v2\nk.3.1.2=v3\n";
outMap = ConfigUtils.toMap(srcKv);
assertEquals(expectedMap, outMap);
// Test delimited by multiple new lines
srcKv = "k.1.1.2=v1\nk.2.1.2=v2\n\nk.3.1.2=v3";
outMap = ConfigUtils.toMap(srcKv);
assertEquals(expectedMap, outMap);
// Test delimited by multiple new lines with spaces in between
srcKv = "k.1.1.2=v1\n \nk.2.1.2=v2\n\nk.3.1.2=v3";
outMap = ConfigUtils.toMap(srcKv);
assertEquals(expectedMap, outMap);
// Test with random spaces if trim works properly
srcKv = " k.1.1.2 = v1\n k.2.1.2 = v2 \nk.3.1.2 = v3";
outMap = ConfigUtils.toMap(srcKv);
assertEquals(expectedMap, outMap);
}
@Test
public void testToMapThrowError() {
String srcKv = "k.1.1.2=v1=v1.1\nk.2.1.2=v2\nk.3.1.2=v3";
assertThrows(IllegalArgumentException.class, () -> ConfigUtils.toMap(srcKv));
}
}