[MINOR] Remove unused methods in HoodieColumnProjectionUtils (#4408)
This commit is contained in:
@@ -19,7 +19,6 @@
|
||||
package org.apache.hudi.hadoop;
|
||||
|
||||
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoUtils;
|
||||
import org.apache.hudi.common.util.CollectionUtils;
|
||||
import org.apache.hudi.common.util.ValidationUtils;
|
||||
import org.apache.hudi.common.util.collection.Pair;
|
||||
|
||||
@@ -32,9 +31,7 @@ import org.slf4j.LoggerFactory;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.Arrays;
|
||||
import java.util.HashSet;
|
||||
import java.util.List;
|
||||
import java.util.Set;
|
||||
import java.util.stream.Collectors;
|
||||
import java.util.stream.IntStream;
|
||||
|
||||
@@ -53,127 +50,9 @@ public class HoodieColumnProjectionUtils {
|
||||
* c:struct_of (a:string,b:string).
|
||||
* the column a's path is c.a and b's path is c.b
|
||||
*/
|
||||
public static final String READ_NESTED_COLUMN_PATH_CONF_STR =
|
||||
"hive.io.file.readNestedColumn.paths";
|
||||
public static final String READ_ALL_COLUMNS = "hive.io.file.read.all.columns";
|
||||
public static final String READ_COLUMN_NAMES_CONF_STR = "hive.io.file.readcolumn.names";
|
||||
private static final String READ_COLUMN_IDS_CONF_STR_DEFAULT = "";
|
||||
private static final String READ_COLUMN_NAMES_CONF_STR_DEFAULT = "";
|
||||
private static final String READ_NESTED_COLUMN_PATH_CONF_STR_DEFAULT = "";
|
||||
private static final boolean READ_ALL_COLUMNS_DEFAULT = true;
|
||||
|
||||
private static final String COMMA = ",";
|
||||
|
||||
/** Special Column Names added during Parquet Projection. **/
|
||||
public static final String PARQUET_BLOCK_OFFSET_COL_NAME = "BLOCK__OFFSET__INSIDE__FILE";
|
||||
public static final String PARQUET_INPUT_FILE_NAME = "INPUT__FILE__NAME";
|
||||
public static final String PARQUET_ROW_ID = "ROW__ID";
|
||||
|
||||
public static final List<String> PARQUET_SPECIAL_COLUMN_NAMES = CollectionUtils
|
||||
.createImmutableList(PARQUET_BLOCK_OFFSET_COL_NAME, PARQUET_INPUT_FILE_NAME,
|
||||
PARQUET_ROW_ID);
|
||||
|
||||
/**
|
||||
* Sets the <em>READ_ALL_COLUMNS</em> flag and removes any previously
|
||||
* set column ids.
|
||||
*/
|
||||
public static void setReadAllColumns(Configuration conf) {
|
||||
conf.setBoolean(READ_ALL_COLUMNS, true);
|
||||
setReadColumnIDConf(conf, READ_COLUMN_IDS_CONF_STR_DEFAULT);
|
||||
setReadColumnNamesConf(conf, READ_COLUMN_NAMES_CONF_STR_DEFAULT);
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the <em>READ_ALL_COLUMNS</em> columns flag.
|
||||
*/
|
||||
public static boolean isReadAllColumns(Configuration conf) {
|
||||
return conf.getBoolean(READ_ALL_COLUMNS, READ_ALL_COLUMNS_DEFAULT);
|
||||
}
|
||||
|
||||
/**
|
||||
* Sets the <em>READ_ALL_COLUMNS</em> flag to false and overwrites column ids
|
||||
* with the provided list.
|
||||
*/
|
||||
public static void setReadColumns(Configuration conf, List<Integer> ids, List<String> names) {
|
||||
setReadColumnIDConf(conf, READ_COLUMN_IDS_CONF_STR_DEFAULT);
|
||||
setReadColumnNamesConf(conf, READ_COLUMN_NAMES_CONF_STR_DEFAULT);
|
||||
appendReadColumns(conf, ids);
|
||||
appendReadColumnNames(conf, names);
|
||||
}
|
||||
|
||||
/**
|
||||
* Appends read columns' ids (start from zero). Once a column
|
||||
* is included in the list, a underlying record reader of a columnar file format
|
||||
* (e.g. RCFile and ORC) can know what columns are needed.
|
||||
*/
|
||||
public static void appendReadColumns(Configuration conf, List<Integer> ids) {
|
||||
String id = toReadColumnIDString(ids);
|
||||
String old = conf.get(READ_COLUMN_IDS_CONF_STR, null);
|
||||
String newConfStr = id;
|
||||
if (old != null && !old.isEmpty()) {
|
||||
newConfStr = newConfStr + StringUtils.COMMA_STR + old;
|
||||
}
|
||||
setReadColumnIDConf(conf, newConfStr);
|
||||
// Set READ_ALL_COLUMNS to false
|
||||
conf.setBoolean(READ_ALL_COLUMNS, false);
|
||||
}
|
||||
|
||||
/**
|
||||
* Appends read nested column's paths. Once a read nested column path
|
||||
* is included in the list, a underlying record reader of a columnar file format
|
||||
* (e.g. Parquet and ORC) can know what columns are needed.
|
||||
*/
|
||||
public static void appendNestedColumnPaths(
|
||||
Configuration conf,
|
||||
List<String> paths) {
|
||||
if (paths == null || paths.isEmpty()) {
|
||||
return;
|
||||
}
|
||||
String pathsStr = StringUtils.join(StringUtils.COMMA_STR,
|
||||
paths.toArray(new String[paths.size()]));
|
||||
String old = conf.get(READ_NESTED_COLUMN_PATH_CONF_STR, null);
|
||||
String newConfStr = pathsStr;
|
||||
if (old != null && !old.isEmpty()) {
|
||||
newConfStr = newConfStr + StringUtils.COMMA_STR + old;
|
||||
}
|
||||
setReadNestedColumnPathConf(conf, newConfStr);
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* This method appends read column information to configuration to use for PPD. It is
|
||||
* currently called with information from TSOP. Names come from TSOP input RowSchema, and
|
||||
* IDs are the indexes inside the schema (which PPD assumes correspond to indexes inside the
|
||||
* files to PPD in; something that would be invalid in many cases of schema evolution).
|
||||
* @param conf Config to set values to.
|
||||
* @param ids Column ids.
|
||||
* @param names Column names.
|
||||
*/
|
||||
public static void appendReadColumns(
|
||||
Configuration conf, List<Integer> ids, List<String> names, List<String> groupPaths) {
|
||||
if (ids.size() != names.size()) {
|
||||
LOG.warn("Read column counts do not match: "
|
||||
+ ids.size() + " ids, " + names.size() + " names");
|
||||
}
|
||||
appendReadColumns(conf, ids);
|
||||
appendReadColumnNames(conf, names);
|
||||
appendNestedColumnPaths(conf, groupPaths);
|
||||
}
|
||||
|
||||
public static void appendReadColumns(
|
||||
StringBuilder readColumnsBuffer, StringBuilder readColumnNamesBuffer, List<Integer> ids,
|
||||
List<String> names) {
|
||||
String preppedIdStr = ids.stream().map(x -> String.valueOf(x)).collect(Collectors.joining(COMMA));
|
||||
String preppedNamesStr = names.stream().collect(Collectors.joining(COMMA));
|
||||
if (readColumnsBuffer.length() > 0) {
|
||||
readColumnsBuffer.append(COMMA);
|
||||
}
|
||||
readColumnsBuffer.append(preppedIdStr);
|
||||
if (readColumnNamesBuffer.length() > 0) {
|
||||
readColumnNamesBuffer.append(COMMA);
|
||||
}
|
||||
readColumnNamesBuffer.append(preppedNamesStr);
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns an array of column ids(start from zero) which is set in the given
|
||||
@@ -197,12 +76,6 @@ public class HoodieColumnProjectionUtils {
|
||||
return result;
|
||||
}
|
||||
|
||||
public static Set<String> getNestedColumnPaths(Configuration conf) {
|
||||
String skips =
|
||||
conf.get(READ_NESTED_COLUMN_PATH_CONF_STR, READ_NESTED_COLUMN_PATH_CONF_STR_DEFAULT);
|
||||
return new HashSet<>(Arrays.asList(StringUtils.split(skips)));
|
||||
}
|
||||
|
||||
public static String[] getReadColumnNames(Configuration conf) {
|
||||
String colNames = conf.get(READ_COLUMN_NAMES_CONF_STR, READ_COLUMN_NAMES_CONF_STR_DEFAULT);
|
||||
if (colNames != null && !colNames.isEmpty()) {
|
||||
@@ -236,65 +109,4 @@ public class HoodieColumnProjectionUtils {
|
||||
.collect(Collectors.toList());
|
||||
}
|
||||
|
||||
public static void setIOColumnNameAndTypes(Configuration conf, List<Pair<String,String>> colNamesAndTypes) {
|
||||
String colNames = colNamesAndTypes.stream().map(e -> e.getKey()).collect(Collectors.joining(","));
|
||||
String colTypes = colNamesAndTypes.stream().map(e -> e.getValue()).collect(Collectors.joining(","));
|
||||
conf.set(IOConstants.COLUMNS, colNames);
|
||||
conf.set(IOConstants.COLUMNS_TYPES, colTypes);
|
||||
}
|
||||
|
||||
private static void setReadColumnIDConf(Configuration conf, String id) {
|
||||
if (id.trim().isEmpty()) {
|
||||
conf.set(READ_COLUMN_IDS_CONF_STR, READ_COLUMN_IDS_CONF_STR_DEFAULT);
|
||||
} else {
|
||||
conf.set(READ_COLUMN_IDS_CONF_STR, id);
|
||||
}
|
||||
}
|
||||
|
||||
private static void setReadColumnNamesConf(Configuration conf, String id) {
|
||||
if (id.trim().isEmpty()) {
|
||||
conf.set(READ_COLUMN_NAMES_CONF_STR, READ_COLUMN_NAMES_CONF_STR_DEFAULT);
|
||||
} else {
|
||||
conf.set(READ_COLUMN_NAMES_CONF_STR, id);
|
||||
}
|
||||
}
|
||||
|
||||
private static void setReadNestedColumnPathConf(
|
||||
Configuration conf,
|
||||
String nestedColumnPaths) {
|
||||
nestedColumnPaths = nestedColumnPaths.toLowerCase();
|
||||
if (nestedColumnPaths.trim().isEmpty()) {
|
||||
conf.set(READ_NESTED_COLUMN_PATH_CONF_STR, READ_NESTED_COLUMN_PATH_CONF_STR_DEFAULT);
|
||||
} else {
|
||||
conf.set(READ_NESTED_COLUMN_PATH_CONF_STR, nestedColumnPaths);
|
||||
}
|
||||
}
|
||||
|
||||
private static void appendReadColumnNames(Configuration conf, List<String> cols) {
|
||||
String old = conf.get(READ_COLUMN_NAMES_CONF_STR, "");
|
||||
StringBuilder result = new StringBuilder(old);
|
||||
boolean first = old.isEmpty();
|
||||
for (String col: cols) {
|
||||
if (first) {
|
||||
first = false;
|
||||
} else {
|
||||
result.append(',');
|
||||
}
|
||||
result.append(col);
|
||||
}
|
||||
conf.set(READ_COLUMN_NAMES_CONF_STR, result.toString());
|
||||
}
|
||||
|
||||
private static String toReadColumnIDString(List<Integer> ids) {
|
||||
String id = "";
|
||||
for (int i = 0; i < ids.size(); i++) {
|
||||
if (i == 0) {
|
||||
id = id + ids.get(i);
|
||||
} else {
|
||||
id = id + StringUtils.COMMA_STR + ids.get(i);
|
||||
}
|
||||
}
|
||||
return id;
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user